From ee1fb647144eea644c226f0d5148826d0c9eb64a Mon Sep 17 00:00:00 2001 From: Shu Yang Date: Mon, 19 Dec 2022 23:18:19 +0000 Subject: [PATCH] [Fixit] Cleanup RequestDesktopSiteForTablets flag Cleanup RequestDesktopSiteForTablets flag as we are experimenting rds based on screen size in inches instead of window size in dp. Bug: 1402539 Change-Id: Icd8aa57f7aed11ff17e37934ee2d9f2b894ce528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117455 Reviewed-by: Sinan Sahin Commit-Queue: Shu Yang Reviewed-by: Gang Wu Reviewed-by: Theresa Sullivan Cr-Commit-Position: refs/heads/main@{#1085185} --- .../chromium/chrome/browser/tab/TabUtils.java | 32 ------- .../TabWebContentsDelegateAndroidImpl.java | 5 -- chrome/browser/about_flags.cc | 44 ---------- .../tab_web_contents_delegate_android.cc | 9 -- .../tab_web_contents_delegate_android.h | 1 - .../browser/chrome_content_browser_client.cc | 4 +- chrome/browser/flag_descriptions.cc | 7 -- chrome/browser/flag_descriptions.h | 3 - .../flags/android/chrome_feature_list.cc | 1 - .../browser/flags/ChromeFeatureList.java | 1 - chrome/common/chrome_features.cc | 6 -- chrome/common/chrome_features.h | 5 -- chrome/common/google_url_loader_throttle.cc | 20 ----- chrome/common/google_url_loader_throttle.h | 2 - .../google_url_loader_throttle_unittest.cc | 84 ------------------- .../url_loader_throttle_provider_impl.cc | 1 - chrome/test/BUILD.gn | 1 - .../metadata/android/histograms.xml | 4 + 18 files changed, 5 insertions(+), 225 deletions(-) delete mode 100644 chrome/common/google_url_loader_throttle_unittest.cc diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabUtils.java index ff2bc45f09099..a7b1589755c72 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabUtils.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabUtils.java @@ -17,11 +17,9 @@ import androidx.annotation.NonNull; import androidx.annotation.Nullable; -import org.chromium.base.ApplicationStatus; import org.chromium.base.MathUtils; import org.chromium.base.annotations.CalledByNative; import org.chromium.chrome.R; -import org.chromium.chrome.browser.flags.ChromeFeatureList; import org.chromium.chrome.browser.profiles.Profile; import org.chromium.chrome.browser.tab.state.CriticalPersistedTabData; import org.chromium.chrome.browser.tasks.tab_management.TabUiFeatureUtilities; @@ -31,7 +29,6 @@ import org.chromium.components.content_settings.ContentSettingsType; import org.chromium.content_public.browser.ContentFeatureList; import org.chromium.content_public.browser.WebContents; -import org.chromium.ui.base.DeviceFormFactor; import org.chromium.ui.base.WindowAndroid; import org.chromium.ui.display.DisplayAndroidManager; import org.chromium.url.GURL; @@ -43,8 +40,6 @@ * Collection of utility methods that operates on Tab. */ public class TabUtils { - private static final String REQUEST_DESKTOP_SCREEN_WIDTH_PARAM = "screen_width_dp"; - /** * Define the callers of NavigationControllerImpl#setUseDesktopUserAgent. */ @@ -204,33 +199,6 @@ public static boolean readRequestDesktopSiteContentSettings( } } - /** - * Check if the tab is large enough for displaying desktop sites. This method will only check - * for tablets, if the device is a phone, will return false regardless of tab size. - * @param tab The tab to be checked if the size is large enough for desktop site. - * @return Whether or not the screen size is large enough for desktop sites. - */ - public static boolean isTabLargeEnoughForDesktopSite(Tab tab) { - if (!DeviceFormFactor.isNonMultiDisplayContextOnTablet(tab.getContext())) { - // The device is a phone, do not check the tab size. - return false; - } - Activity activity = getActivity(tab); - if (activity == null) { - // It is possible that we are in custom tabs or tests, and need to access the activity - // differently. - activity = ApplicationStatus.getLastTrackedFocusedActivity(); - if (activity == null) return false; - } - int windowWidth = activity.getWindow().getDecorView().getWidth(); - int minWidthForDesktopSite = ChromeFeatureList.getFieldTrialParamByFeatureAsInt( - ChromeFeatureList.REQUEST_DESKTOP_SITE_FOR_TABLETS, - REQUEST_DESKTOP_SCREEN_WIDTH_PARAM, - /* Set a very large size as default to serve as a disabled screen width. */ 4096); - - return minWidthForDesktopSite <= windowWidth; - } - /** * Check if Request Desktop Site global setting is enabled. * @param profile The profile of the tab. diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroidImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroidImpl.java index 0d7122b3c8575..558c93d7b5852 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroidImpl.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroidImpl.java @@ -314,11 +314,6 @@ protected boolean canShowAppBanners() { return mDelegate.canShowAppBanners(); } - @CalledByNative - private boolean isTabLargeEnoughForDesktopSite() { - return TabUtils.isTabLargeEnoughForDesktopSite(mTab); - } - /** * @return the WebAPK manifest scope. This gives frames within the scope increased privileges * such as autoplaying media unmuted. diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc index 270954c57263b..0f887656b2858 100644 --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -2489,44 +2489,6 @@ const FeatureEntry::FeatureVariation kPhotoPickerVideoSupportEnabledWithAnimatedThumbnails, std::size(kPhotoPickerVideoSupportEnabledWithAnimatedThumbnails), nullptr}}; - -// Request Desktop Site on Tablet by default variations. -const FeatureEntry::FeatureParam kRequestDesktopSiteForTablets100[] = { - {"screen_width_dp", "100"}, - {"enabled", "true"}}; -const FeatureEntry::FeatureParam kRequestDesktopSiteForTablets600[] = { - {"screen_width_dp", "600"}, - {"enabled", "true"}}; -const FeatureEntry::FeatureParam kRequestDesktopSiteForTablets768[] = { - {"screen_width_dp", "768"}, - {"enabled", "true"}}; -const FeatureEntry::FeatureParam kRequestDesktopSiteForTablets960[] = { - {"screen_width_dp", "960"}, - {"enabled", "true"}}; -const FeatureEntry::FeatureParam kRequestDesktopSiteForTablets1024[] = { - {"screen_width_dp", "1024"}, - {"enabled", "true"}}; -const FeatureEntry::FeatureParam kRequestDesktopSiteForTablets1280[] = { - {"screen_width_dp", "1280"}, - {"enabled", "true"}}; -const FeatureEntry::FeatureParam kRequestDesktopSiteForTablets1920[] = { - {"screen_width_dp", "1920"}, - {"enabled", "true"}}; -const FeatureEntry::FeatureVariation kRequestDesktopSiteForTabletsVariations[] = - {{"for 100dp+ screens", kRequestDesktopSiteForTablets100, - std::size(kRequestDesktopSiteForTablets100), nullptr}, - {"for 600dp+ screens", kRequestDesktopSiteForTablets600, - std::size(kRequestDesktopSiteForTablets600), nullptr}, - {"for 768dp+ screens", kRequestDesktopSiteForTablets768, - std::size(kRequestDesktopSiteForTablets768), nullptr}, - {"for 960dp+ screens", kRequestDesktopSiteForTablets960, - std::size(kRequestDesktopSiteForTablets960), nullptr}, - {"for 1024dp+ screens", kRequestDesktopSiteForTablets1024, - std::size(kRequestDesktopSiteForTablets1024), nullptr}, - {"for 1280dp+ screens", kRequestDesktopSiteForTablets1280, - std::size(kRequestDesktopSiteForTablets1280), nullptr}, - {"for 1920dp+ screens", kRequestDesktopSiteForTablets1920, - std::size(kRequestDesktopSiteForTablets1920), nullptr}}; #endif // BUILDFLAG(IS_ANDROID) // TODO(crbug.com/991082,1015377): Remove after proper support for back/forward @@ -5399,12 +5361,6 @@ const FeatureEntry kFeatureEntries[] = { #endif // BUILDFLAG(IS_ANDROID) #if BUILDFLAG(IS_ANDROID) - {"request-desktop-site-for-tablets", - flag_descriptions::kRequestDesktopSiteForTabletsName, - flag_descriptions::kRequestDesktopSiteForTabletsDescription, kOsAndroid, - FEATURE_WITH_PARAMS_VALUE_TYPE(features::kRequestDesktopSiteForTablets, - kRequestDesktopSiteForTabletsVariations, - "RequestDesktopSiteForTablets")}, {"revoke-notifications-permission-if-disabled-on-app-level", flag_descriptions::kRevokeNotificationsPermissionIfDisabledOnAppLevelName, flag_descriptions:: diff --git a/chrome/browser/android/tab_web_contents_delegate_android.cc b/chrome/browser/android/tab_web_contents_delegate_android.cc index ad1152cf434ae..5cb2d0d76422c 100644 --- a/chrome/browser/android/tab_web_contents_delegate_android.cc +++ b/chrome/browser/android/tab_web_contents_delegate_android.cc @@ -580,15 +580,6 @@ bool TabWebContentsDelegateAndroid::CanShowAppBanners() const { return Java_TabWebContentsDelegateAndroidImpl_canShowAppBanners(env, obj); } -bool TabWebContentsDelegateAndroid::IsTabLargeEnoughForDesktopSite() const { - JNIEnv* env = base::android::AttachCurrentThread(); - ScopedJavaLocalRef obj = GetJavaDelegate(env); - if (obj.is_null()) - return false; - return Java_TabWebContentsDelegateAndroidImpl_isTabLargeEnoughForDesktopSite( - env, obj); -} - const GURL TabWebContentsDelegateAndroid::GetManifestScope() const { JNIEnv* env = base::android::AttachCurrentThread(); ScopedJavaLocalRef obj = GetJavaDelegate(env); diff --git a/chrome/browser/android/tab_web_contents_delegate_android.h b/chrome/browser/android/tab_web_contents_delegate_android.h index 0cbb02e8882df..0507b46d11136 100644 --- a/chrome/browser/android/tab_web_contents_delegate_android.h +++ b/chrome/browser/android/tab_web_contents_delegate_android.h @@ -130,7 +130,6 @@ class TabWebContentsDelegateAndroid bool IsNightModeEnabled() const; bool IsForceDarkWebContentEnabled() const; bool CanShowAppBanners() const; - bool IsTabLargeEnoughForDesktopSite() const; // Returns true if this tab is currently presented in the context of custom // tabs. Tabs can be moved between different activities so the returned value diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc index 3b0d49489c4f1..5dd6005f275dc 100644 --- a/chrome/browser/chrome_content_browser_client.cc +++ b/chrome/browser/chrome_content_browser_client.cc @@ -5362,7 +5362,6 @@ ChromeContentBrowserClient::CreateURLLoaderThrottles( #if BUILDFLAG(IS_ANDROID) std::string client_data_header; - bool is_tab_large_enough = false; bool is_custom_tab = false; if (frame_tree_node_id != content::RenderFrameHost::kNoFrameTreeNodeId) { auto* web_contents = WebContents::FromFrameTreeNodeId(frame_tree_node_id); @@ -5380,7 +5379,6 @@ ChromeContentBrowserClient::CreateURLLoaderThrottles( web_contents->GetDelegate()) : nullptr; if (delegate) { - is_tab_large_enough = delegate->IsTabLargeEnoughForDesktopSite(); is_custom_tab = delegate->IsCustomTab(); } } @@ -5393,7 +5391,7 @@ ChromeContentBrowserClient::CreateURLLoaderThrottles( profile->GetPrefs()->GetString(prefs::kAllowedDomainsForApps)}; result.push_back(std::make_unique( #if BUILDFLAG(IS_ANDROID) - client_data_header, is_tab_large_enough, + client_data_header, #endif std::move(dynamic_params))); diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc index 11e4ab0428c45..4a49805ac05eb 100644 --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc @@ -3909,13 +3909,6 @@ const char kRequestDesktopSiteExceptionsDescription[] = "An option in `Site settings` to request the desktop version of websites " "based on site level settings."; -const char kRequestDesktopSiteForTabletsName[] = - "Request desktop site for tablets on Android"; -const char kRequestDesktopSiteForTabletsDescription[] = - "Requests a desktop site, if the screen size is large enough on Android." - " On tablets with small screens a mobile site will be requested by " - "default."; - const char kRequestDesktopSiteZoomName[] = "Default zoom for request desktop site on Android."; const char kRequestDesktopSiteZoomDescription[] = diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h index b1484db0749b1..04d6216b14275 100644 --- a/chrome/browser/flag_descriptions.h +++ b/chrome/browser/flag_descriptions.h @@ -2239,9 +2239,6 @@ extern const char kRequestDesktopSiteExceptionsDescription[]; extern const char kRequestDesktopSiteExceptionsDowngradeName[]; extern const char kRequestDesktopSiteExceptionsDowngradeDescription[]; -extern const char kRequestDesktopSiteForTabletsName[]; -extern const char kRequestDesktopSiteForTabletsDescription[]; - extern const char kRequestDesktopSiteZoomName[]; extern const char kRequestDesktopSiteZoomDescription[]; diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc index f93b0d967b019..96d464fc8274f 100644 --- a/chrome/browser/flags/android/chrome_feature_list.cc +++ b/chrome/browser/flags/android/chrome_feature_list.cc @@ -125,7 +125,6 @@ const base::Feature* const kFeaturesExposedToJava[] = { &features::kPwaUpdateDialogForIcon, &features::kPwaUpdateDialogForName, &features::kQuietNotificationPrompts, - &features::kRequestDesktopSiteForTablets, &features::kToolbarUseHardwareBitmapDraw, &features::kWebNfc, &features::kIncognitoDownloadsWarning, diff --git a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java index ce20c0f1d03f2..3fd20147e60ef 100644 --- a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java +++ b/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java @@ -464,7 +464,6 @@ public static boolean getFieldTrialParamByFeatureAsBoolean( "RequestDesktopSiteOptInSynthetic"; public static final String REQUEST_DESKTOP_SITE_OPT_IN_CONTROL_SYNTHETIC = "RequestDesktopSiteOptInControlSynthetic"; - public static final String REQUEST_DESKTOP_SITE_FOR_TABLETS = "RequestDesktopSiteForTablets"; public static final String SAFE_BROWSING_DELAYED_WARNINGS = "SafeBrowsingDelayedWarnings"; public static final String SAFE_MODE_FOR_CACHED_FLAGS = "SafeModeForCachedFlags"; public static final String SCREENSHOTS_FOR_ANDROID_V2 = "ScreenshotsForAndroidV2"; diff --git a/chrome/common/chrome_features.cc b/chrome/common/chrome_features.cc index afc98d10abcef..1d245f8115620 100644 --- a/chrome/common/chrome_features.cc +++ b/chrome/common/chrome_features.cc @@ -966,12 +966,6 @@ BASE_FEATURE(kRemoveSupervisedUsersOnStartup, base::FEATURE_DISABLED_BY_DEFAULT); #endif -#if BUILDFLAG(IS_ANDROID) -BASE_FEATURE(kRequestDesktopSiteForTablets, - "RequestDesktopSiteForTablets", - base::FEATURE_DISABLED_BY_DEFAULT); -#endif - #if !BUILDFLAG(IS_ANDROID) // Enables notification permission module in Safety Check. BASE_FEATURE(kSafetyCheckNotificationPermissions, diff --git a/chrome/common/chrome_features.h b/chrome/common/chrome_features.h index 045fdc78cb4c0..f1961d2b7e0be 100644 --- a/chrome/common/chrome_features.h +++ b/chrome/common/chrome_features.h @@ -548,11 +548,6 @@ COMPONENT_EXPORT(CHROME_FEATURES) BASE_DECLARE_FEATURE(kRemoveSupervisedUsersOnStartup); #endif -#if BUILDFLAG(IS_ANDROID) -COMPONENT_EXPORT(CHROME_FEATURES) -BASE_DECLARE_FEATURE(kRequestDesktopSiteForTablets); -#endif - #if !BUILDFLAG(IS_ANDROID) COMPONENT_EXPORT(CHROME_FEATURES) BASE_DECLARE_FEATURE(kSafetyCheckNotificationPermissions); diff --git a/chrome/common/google_url_loader_throttle.cc b/chrome/common/google_url_loader_throttle.cc index a29a2739af3c8..546ec3a4dcd10 100644 --- a/chrome/common/google_url_loader_throttle.cc +++ b/chrome/common/google_url_loader_throttle.cc @@ -15,10 +15,6 @@ #include "services/network/public/mojom/url_response_head.mojom.h" #include "services/network/public/mojom/x_frame_options.mojom.h" -#if BUILDFLAG(IS_ANDROID) -#include "ui/base/device_form_factor.h" -#endif - #if BUILDFLAG(ENABLE_EXTENSIONS) #include "extensions/common/extension_urls.h" #endif @@ -27,7 +23,6 @@ namespace { #if BUILDFLAG(IS_ANDROID) const char kCCTClientDataHeader[] = "X-CCT-Client-Data"; -const char kRequestDesktopDataHeader[] = "X-Eligible-Tablet"; #endif } // namespace @@ -47,13 +42,11 @@ void GoogleURLLoaderThrottle::UpdateCorsExemptHeader( GoogleURLLoaderThrottle::GoogleURLLoaderThrottle( #if BUILDFLAG(IS_ANDROID) const std::string& client_data_header, - bool is_tab_large_enough, #endif chrome::mojom::DynamicParams dynamic_params) : #if BUILDFLAG(IS_ANDROID) client_data_header_(client_data_header), - is_tab_large_enough_(is_tab_large_enough), #endif dynamic_params_(std::move(dynamic_params)) { } @@ -97,19 +90,6 @@ void GoogleURLLoaderThrottle::WillStartRequest( request->cors_exempt_headers.SetHeader(kCCTClientDataHeader, client_data_header_); } - - bool is_google_homepage_or_search = - google_util::IsGoogleHomePageUrl(request->url) || - google_util::IsGoogleSearchUrl(request->url); - if (is_google_homepage_or_search) { - if (base::FeatureList::IsEnabled(features::kRequestDesktopSiteForTablets) && - ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_TABLET) { - request->headers.SetHeader(kRequestDesktopDataHeader, - is_tab_large_enough_ ? "1" : "0"); - base::UmaHistogramBoolean("Android.RequestDesktopSite.TabletEligible", - is_tab_large_enough_); - } - } #endif } diff --git a/chrome/common/google_url_loader_throttle.h b/chrome/common/google_url_loader_throttle.h index 4c48ac4d48db6..f4af6fab0f687 100644 --- a/chrome/common/google_url_loader_throttle.h +++ b/chrome/common/google_url_loader_throttle.h @@ -20,7 +20,6 @@ class GoogleURLLoaderThrottle public: #if BUILDFLAG(IS_ANDROID) GoogleURLLoaderThrottle(const std::string& client_data_header, - bool is_tab_large_enough, chrome::mojom::DynamicParams dynamic_params); #else explicit GoogleURLLoaderThrottle(chrome::mojom::DynamicParams dynamic_params); @@ -51,7 +50,6 @@ class GoogleURLLoaderThrottle private: #if BUILDFLAG(IS_ANDROID) std::string client_data_header_; - bool is_tab_large_enough_; #endif const chrome::mojom::DynamicParams dynamic_params_; }; diff --git a/chrome/common/google_url_loader_throttle_unittest.cc b/chrome/common/google_url_loader_throttle_unittest.cc deleted file mode 100644 index 50ffab96e5c6b..0000000000000 --- a/chrome/common/google_url_loader_throttle_unittest.cc +++ /dev/null @@ -1,84 +0,0 @@ -// Copyright 2020 The Chromium Authors -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "chrome/common/google_url_loader_throttle.h" - -#include "base/test/scoped_feature_list.h" -#include "build/build_config.h" -#include "chrome/common/chrome_features.h" -#include "chrome/common/renderer_configuration.mojom.h" -#include "services/network/public/cpp/resource_request.h" -#include "testing/gtest/include/gtest/gtest.h" - -#if BUILDFLAG(IS_ANDROID) -#include "ui/base/device_form_factor.h" -#endif - -class GoogleURLLoaderThrottleTest : public testing::Test { - public: - GoogleURLLoaderThrottleTest() { - scoped_feature_list_.InitWithFeatureList( - std::make_unique()); - } - - ~GoogleURLLoaderThrottleTest() override = default; - - base::test::ScopedFeatureList& scoped_feature_list() { - return scoped_feature_list_; - } - - private: - base::test::ScopedFeatureList scoped_feature_list_; -}; - -#if BUILDFLAG(IS_ANDROID) - -TEST_F(GoogleURLLoaderThrottleTest, RequestDesktopHeaderForLargeScreen) { - scoped_feature_list().Reset(); - scoped_feature_list().InitAndEnableFeature( - features::kRequestDesktopSiteForTablets); - GoogleURLLoaderThrottle throttle(/* client_header= */ "", - /* is_tab_large_enough= */ true, - chrome::mojom::DynamicParams()); - - network::ResourceRequest request; - request.url = GURL("https://www.google.com"); - bool defer = false; - - throttle.WillStartRequest(&request, &defer); - - // Only set header for tablets, not for phone. - if (ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_TABLET) { - std::string isTablet; - EXPECT_TRUE(request.headers.GetHeader("X-Eligible-Tablet", &isTablet)); - EXPECT_EQ(isTablet, "1"); - } else { - EXPECT_FALSE(request.headers.HasHeader("X-Eligible-Tablet")); - } -} - -TEST_F(GoogleURLLoaderThrottleTest, RequestDesktopHeaderForSmallScreen) { - scoped_feature_list().Reset(); - scoped_feature_list().InitAndEnableFeature( - features::kRequestDesktopSiteForTablets); - GoogleURLLoaderThrottle throttle(/* client_header= */ "", - /* is_tab_large_enough= */ false, - chrome::mojom::DynamicParams()); - - network::ResourceRequest request; - request.url = GURL("https://www.google.com"); - bool defer = false; - - throttle.WillStartRequest(&request, &defer); - - // Only set header for tablets, not for phone. - if (ui::GetDeviceFormFactor() == ui::DEVICE_FORM_FACTOR_TABLET) { - std::string isTablet; - EXPECT_TRUE(request.headers.GetHeader("X-Eligible-Tablet", &isTablet)); - EXPECT_EQ(isTablet, "0"); - } else { - EXPECT_FALSE(request.headers.HasHeader("X-Eligible-Tablet")); - } -} -#endif diff --git a/chrome/renderer/url_loader_throttle_provider_impl.cc b/chrome/renderer/url_loader_throttle_provider_impl.cc index 976379346ccf9..64f1ae54093f4 100644 --- a/chrome/renderer/url_loader_throttle_provider_impl.cc +++ b/chrome/renderer/url_loader_throttle_provider_impl.cc @@ -184,7 +184,6 @@ URLLoaderThrottleProviderImpl::CreateThrottles( throttles.emplace_back(std::make_unique( #if BUILDFLAG(IS_ANDROID) client_data_header, - /* is_tab_large_enough= */ false, #endif ChromeRenderThreadObserver::GetDynamicParams())); diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn index 5048112060c93..6faa84f925a59 100644 --- a/chrome/test/BUILD.gn +++ b/chrome/test/BUILD.gn @@ -5690,7 +5690,6 @@ test("unit_tests") { "../common/chrome_content_client_unittest.cc", "../common/chrome_paths_unittest.cc", "../common/crash_keys_unittest.cc", - "../common/google_url_loader_throttle_unittest.cc", "../common/ini_parser_unittest.cc", "../common/net/safe_search_util_unittest.cc", "../common/pref_names_util_unittest.cc", diff --git a/tools/metrics/histograms/metadata/android/histograms.xml b/tools/metrics/histograms/metadata/android/histograms.xml index 0c700813e6c14..2a5e331a5ac91 100644 --- a/tools/metrics/histograms/metadata/android/histograms.xml +++ b/tools/metrics/histograms/metadata/android/histograms.xml @@ -3117,6 +3117,10 @@ chromium-metrics-reviews@google.com. + + Deprecated in December 2022. This is no longer recorded as we cleanup + feature flag RequestDesktopSiteForTablets. + gangwu@chromium.org fgorski@chromium.org