From f013e6d82d1c0d6238e3a4fada6e58d11672f870 Mon Sep 17 00:00:00 2001 From: Joey Arhar Date: Tue, 7 Dec 2021 22:58:19 +0000 Subject: [PATCH] Port chrome-only dialog tests to WPT part 3 Bug: 1240798 Change-Id: Id1e38606a8ec0b59fa5172baa7649d31979267f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3315600 Commit-Queue: Joey Arhar Reviewed-by: Mason Freed Cr-Commit-Position: refs/heads/main@{#949223} --- third_party/blink/web_tests/SmokeTests | 2 +- third_party/blink/web_tests/TestExpectations | 1 + .../the-dialog-element/inert-inlines.html | 85 ++++++++++++++ .../the-dialog-element/inert-label-focus.html | 50 ++++++++ .../inert-node-is-uneditable.html | 55 +++++++++ .../inert-node-is-unselectable.html | 19 +++ .../modal-dialog-ancestor-is-inert.html | 101 ++++++++++++++++ .../modal-dialog-blocks-mouse-events.html | 99 ++++++++++++++++ .../html/dialog/inert-inlines-expected.txt | 24 ---- .../web_tests/html/dialog/inert-inlines.html | 79 ------------- .../dialog/inert-label-focus-expected.txt | 14 --- .../html/dialog/inert-label-focus.html | 44 ------- .../inert-node-is-uneditable-expected.txt | 10 -- .../html/dialog/inert-node-is-uneditable.html | 60 ---------- .../inert-node-is-unselectable-expected.txt | 11 -- .../dialog/inert-node-is-unselectable.html | 18 --- ...odal-dialog-ancestor-is-inert-expected.txt | 18 --- .../modal-dialog-ancestor-is-inert.html | 111 ------------------ ...al-dialog-blocks-mouse-events-expected.txt | 14 --- .../modal-dialog-blocks-mouse-events.html | 97 --------------- 20 files changed, 411 insertions(+), 501 deletions(-) create mode 100644 third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-inlines.html create mode 100644 third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-label-focus.html create mode 100644 third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-uneditable.html create mode 100644 third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unselectable.html create mode 100644 third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/modal-dialog-ancestor-is-inert.html create mode 100644 third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/modal-dialog-blocks-mouse-events.html delete mode 100644 third_party/blink/web_tests/html/dialog/inert-inlines-expected.txt delete mode 100644 third_party/blink/web_tests/html/dialog/inert-inlines.html delete mode 100644 third_party/blink/web_tests/html/dialog/inert-label-focus-expected.txt delete mode 100644 third_party/blink/web_tests/html/dialog/inert-label-focus.html delete mode 100644 third_party/blink/web_tests/html/dialog/inert-node-is-uneditable-expected.txt delete mode 100644 third_party/blink/web_tests/html/dialog/inert-node-is-uneditable.html delete mode 100644 third_party/blink/web_tests/html/dialog/inert-node-is-unselectable-expected.txt delete mode 100644 third_party/blink/web_tests/html/dialog/inert-node-is-unselectable.html delete mode 100644 third_party/blink/web_tests/html/dialog/modal-dialog-ancestor-is-inert-expected.txt delete mode 100644 third_party/blink/web_tests/html/dialog/modal-dialog-ancestor-is-inert.html delete mode 100644 third_party/blink/web_tests/html/dialog/modal-dialog-blocks-mouse-events-expected.txt delete mode 100644 third_party/blink/web_tests/html/dialog/modal-dialog-blocks-mouse-events.html diff --git a/third_party/blink/web_tests/SmokeTests b/third_party/blink/web_tests/SmokeTests index f4226f31b2e4f..46e526c3b907b 100644 --- a/third_party/blink/web_tests/SmokeTests +++ b/third_party/blink/web_tests/SmokeTests @@ -768,7 +768,7 @@ html5lib/generated/run-tests24-write.html html/details_summary/details-clone.html html/details_summary/details-element-render-inline-crash.html html/details_summary/details-summary-document-child.html -html/dialog/inert-label-focus.html +external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-label-focus.html html/grouping_content/figure-element.html html/marquee/marquee-inside-template-tag-crash.html html/sections/article-element.html diff --git a/third_party/blink/web_tests/TestExpectations b/third_party/blink/web_tests/TestExpectations index df761315c13f4..df149f1333d0c 100644 --- a/third_party/blink/web_tests/TestExpectations +++ b/third_party/blink/web_tests/TestExpectations @@ -2508,6 +2508,7 @@ crbug.com/893480 [ Win ] external/wpt/input-events/input-events-cut-paste.html [ crbug.com/893480 external/wpt/html/semantics/forms/the-input-element/checkable-active-onblur.html [ Failure Timeout ] crbug.com/893480 external/wpt/html/semantics/forms/the-button-element/active-onblur.html [ Failure Timeout ] crbug.com/893480 external/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-canceling.html [ Failure ] +crbug.com/893480 external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-uneditable.html [ Failure ] # needs implementation of test_driver_internal.action_sequence # for these tests there is an exception when scrolling: element click intercepted error diff --git a/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-inlines.html b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-inlines.html new file mode 100644 index 0000000000000..8acdb570fc602 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-inlines.html @@ -0,0 +1,85 @@ + + + + + + + + + + + +

+To test manually, click on all the "Click me"s. +The test fails if you see red. +

+ + + +Click me + +
Click meeee
+Click me +
+ Click meeee + +
+ + diff --git a/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-label-focus.html b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-label-focus.html new file mode 100644 index 0000000000000..ee0c91c412098 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-label-focus.html @@ -0,0 +1,50 @@ + + + + + + + + + + + + + + + + + + diff --git a/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-uneditable.html b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-uneditable.html new file mode 100644 index 0000000000000..393e5e10b52e3 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-uneditable.html @@ -0,0 +1,55 @@ + + + + + + + + + + + +I'm not editable while the dialog is showing. + + I'm editable. + + + diff --git a/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unselectable.html b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unselectable.html new file mode 100644 index 0000000000000..2889e1e90a563 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unselectable.html @@ -0,0 +1,19 @@ + + + + + + + + +Here is a text node you can't select while the dialog is open. +I'm selectable. + + diff --git a/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/modal-dialog-ancestor-is-inert.html b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/modal-dialog-ancestor-is-inert.html new file mode 100644 index 0000000000000..c6bcb5d4caf35 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/modal-dialog-ancestor-is-inert.html @@ -0,0 +1,101 @@ + + + + + + + + + + + + + +
+ +
+ + diff --git a/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/modal-dialog-blocks-mouse-events.html b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/modal-dialog-blocks-mouse-events.html new file mode 100644 index 0000000000000..75eb451f58360 --- /dev/null +++ b/third_party/blink/web_tests/external/wpt/html/semantics/interactive-elements/the-dialog-element/modal-dialog-blocks-mouse-events.html @@ -0,0 +1,99 @@ + + + + + + + + + + + +

+To test manually, move the mouse to the blue box, click, and then move the +mouse outside. Then repeat for the red box. The test succeeds if both boxes +turn green +

+ + + +
+ +
+
+ + diff --git a/third_party/blink/web_tests/html/dialog/inert-inlines-expected.txt b/third_party/blink/web_tests/html/dialog/inert-inlines-expected.txt deleted file mode 100644 index 867d0ae6c92c8..0000000000000 --- a/third_party/blink/web_tests/html/dialog/inert-inlines-expected.txt +++ /dev/null @@ -1,24 +0,0 @@ -Tests that inert inlines do not receive mouse events. To test manually, click on all the "Click me"s. The test fails if you see red. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -clicking on a -PASS inertElementFiredOn is false -PASS expectedTarget.firedOn is true -clicking on button -PASS inertElementFiredOn is false -PASS expectedTarget.firedOn is true -clicking on div -PASS inertElementFiredOn is false -PASS expectedTarget.firedOn is true -clicking on span -PASS inertElementFiredOn is false -PASS expectedTarget.firedOn is true -PASS successfullyParsed is true - -TEST COMPLETE - -Click me Click me -Click meeee -Click me -Click meeee diff --git a/third_party/blink/web_tests/html/dialog/inert-inlines.html b/third_party/blink/web_tests/html/dialog/inert-inlines.html deleted file mode 100644 index e050ce072861c..0000000000000 --- a/third_party/blink/web_tests/html/dialog/inert-inlines.html +++ /dev/null @@ -1,79 +0,0 @@ - - - - - - - -Click me - -
Click meeee
-Click me -
- Click meeee - -
- - - diff --git a/third_party/blink/web_tests/html/dialog/inert-label-focus-expected.txt b/third_party/blink/web_tests/html/dialog/inert-label-focus-expected.txt deleted file mode 100644 index 9f360b6659124..0000000000000 --- a/third_party/blink/web_tests/html/dialog/inert-label-focus-expected.txt +++ /dev/null @@ -1,14 +0,0 @@ -Tests focusing of an inert label for a non-inert target. label.focus() should send focus to the target, but clicking the label should be the same as clicking on the document body. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -Testing that calling focus() on label sends focus to its target. -PASS document.activeElement is document.querySelector('#submit') -Testing that clicking on the label sends focus to document.body. -PASS document.activeElement is document.body -PASS successfullyParsed is true - -TEST COMPLETE - -Label for Submit - diff --git a/third_party/blink/web_tests/html/dialog/inert-label-focus.html b/third_party/blink/web_tests/html/dialog/inert-label-focus.html deleted file mode 100644 index 73fce0922507f..0000000000000 --- a/third_party/blink/web_tests/html/dialog/inert-label-focus.html +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - - - - - diff --git a/third_party/blink/web_tests/html/dialog/inert-node-is-uneditable-expected.txt b/third_party/blink/web_tests/html/dialog/inert-node-is-uneditable-expected.txt deleted file mode 100644 index 5f825bbc65e17..0000000000000 --- a/third_party/blink/web_tests/html/dialog/inert-node-is-uneditable-expected.txt +++ /dev/null @@ -1,10 +0,0 @@ -Test that inert nodes cannot be edited. The test passes if the only text you can edit is in the dialog. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -PASS notEditable.textContent is oldValue -PASS editable.textContent is not oldValue -PASS successfullyParsed is true - -TEST COMPLETE - diff --git a/third_party/blink/web_tests/html/dialog/inert-node-is-uneditable.html b/third_party/blink/web_tests/html/dialog/inert-node-is-uneditable.html deleted file mode 100644 index 850171a7ba76d..0000000000000 --- a/third_party/blink/web_tests/html/dialog/inert-node-is-uneditable.html +++ /dev/null @@ -1,60 +0,0 @@ - - - - - - -I'm not editable. - - I'm editable. - - - - diff --git a/third_party/blink/web_tests/html/dialog/inert-node-is-unselectable-expected.txt b/third_party/blink/web_tests/html/dialog/inert-node-is-unselectable-expected.txt deleted file mode 100644 index cb2f35916aab0..0000000000000 --- a/third_party/blink/web_tests/html/dialog/inert-node-is-unselectable-expected.txt +++ /dev/null @@ -1,11 +0,0 @@ -Test that inert nodes cannot be selected. The test passes if the only text you can select is inside the dialog. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -PASS window.getSelection().toString() is "I'm selectable." -PASS successfullyParsed is true - -TEST COMPLETE - -Here is a text node you can't select. -I'm selectable. diff --git a/third_party/blink/web_tests/html/dialog/inert-node-is-unselectable.html b/third_party/blink/web_tests/html/dialog/inert-node-is-unselectable.html deleted file mode 100644 index 848a70bcd864c..0000000000000 --- a/third_party/blink/web_tests/html/dialog/inert-node-is-unselectable.html +++ /dev/null @@ -1,18 +0,0 @@ - - - - - - -Here is a text node you can't select. -I'm selectable. - - - diff --git a/third_party/blink/web_tests/html/dialog/modal-dialog-ancestor-is-inert-expected.txt b/third_party/blink/web_tests/html/dialog/modal-dialog-ancestor-is-inert-expected.txt deleted file mode 100644 index 1245060cf2f66..0000000000000 --- a/third_party/blink/web_tests/html/dialog/modal-dialog-ancestor-is-inert-expected.txt +++ /dev/null @@ -1,18 +0,0 @@ -Test that ancestors of modal are inert. To test manually, click the left box. There should be no change. Then click the right box. If both boxes turn green, the test passes. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -Clicking on ancestor -PASS handledEvent.document is true -PASS handledEvent.body is false -PASS handledEvent.dialog is false -PASS handledEvent.div is false -Clicking on dialog -PASS handledEvent.document is true -PASS handledEvent.body is true -PASS handledEvent.dialog is true -PASS handledEvent.div is true -PASS successfullyParsed is true - -TEST COMPLETE - diff --git a/third_party/blink/web_tests/html/dialog/modal-dialog-ancestor-is-inert.html b/third_party/blink/web_tests/html/dialog/modal-dialog-ancestor-is-inert.html deleted file mode 100644 index ea0d9c6595c7b..0000000000000 --- a/third_party/blink/web_tests/html/dialog/modal-dialog-ancestor-is-inert.html +++ /dev/null @@ -1,111 +0,0 @@ - - - - - - - -
- -
- - - diff --git a/third_party/blink/web_tests/html/dialog/modal-dialog-blocks-mouse-events-expected.txt b/third_party/blink/web_tests/html/dialog/modal-dialog-blocks-mouse-events-expected.txt deleted file mode 100644 index 64f6953910228..0000000000000 --- a/third_party/blink/web_tests/html/dialog/modal-dialog-blocks-mouse-events-expected.txt +++ /dev/null @@ -1,14 +0,0 @@ -Test for bug 110952. Ensure that mouse events are not dispatched to an inert node. To test manually, move the mouse to the blue box, click, and then move the mouse outside. Then repeat for the red box. The test succeeds if both boxes turn green. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - -Clicking on inert box -PASS inertDivHandledEvent is false -PASS Object.keys(handledEvents.document).length is expectedEventCountForDocument -Clicking on non-inert box -PASS inertDivHandledEvent is false -PASS Object.keys(handledEvents.dialogDiv).length is events.length -PASS successfullyParsed is true - -TEST COMPLETE - diff --git a/third_party/blink/web_tests/html/dialog/modal-dialog-blocks-mouse-events.html b/third_party/blink/web_tests/html/dialog/modal-dialog-blocks-mouse-events.html deleted file mode 100644 index 3c6db4ab6b47e..0000000000000 --- a/third_party/blink/web_tests/html/dialog/modal-dialog-blocks-mouse-events.html +++ /dev/null @@ -1,97 +0,0 @@ - - - - - - - -
- -
-
- - -