Commits on Nov 21, 2019
-
Fix ESLint no-var, prefer-const violations in components/security_int…
…erstitials/ Most of these have been fixed automatically with ESLint's --fix flag. This is in preparation of turning on presubmit checks for no-var and prefer-const for components/. Bug: 792774 Change-Id: I8fd0e9e657504be9759f578c23e2461cb3aeeb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924793 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#717453}
Commits on Nov 15, 2019
-
Add a new interstitial for blocked interception certs
This CL adds a new interstitial with custom strings and makes it viewable from chrome://interstitials page. It does not yet hook into the SSL error handler path to trigger the interstitial based on the new net error. Bug: 1014711 Change-Id: Ia66567cbb825c35910745aad181006041ae5b537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913882 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#715520}
Commits on Nov 7, 2019
-
Fix remaining web_dev_style violations under src/components.
This is in preparation of turning on such PRESUBMIT checks for src/components. Bug: 1019312 Change-Id: I352cf547b8ea51cb6eba3a8715122c2129948cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902065 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#713484}
Commits on Oct 30, 2019
-
Fix auto-fixable ESLint violations under components/.
CL produced with ESLint --fix and clang-format. This is in preparation of turning on web-dev style related PRESBUMIT checks for this folder. Bug: 1019312 Change-Id: I6e8400d2125b55a1a22603eb7d81f1889d914b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887840 Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710556}
Commits on Sep 11, 2019
-
[Origin Policy] De-scare the Origin policy interstitial.
The current origin policy interstitial uses the all-red super danger interstitials style, and the text messages indicate an imemdiate security threat (which could be true, but it might also be a simple mis-configuration). This changes this to an SSL-error-like interstitial design, and a more neutral language. Bug: 971598, 751996 Change-Id: I31dba2ae7646eb1e2ee747ab93c9854516ffeddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795604 Reviewed-by: Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#695591}
Commits on Aug 23, 2019
Commits on Jul 31, 2019
Commits on Jun 14, 2019
Commits on Mar 20, 2019
Commits on Feb 6, 2019
Commits on Feb 4, 2019
-
Origin Policy: Move interstital to security_interstitials::* infrastr…
…ucture. Bug: 751996 Change-Id: Iaa56743499b2cffbff3fe59a9207479953786bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1439536 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by: Carlos IL <carlosil@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#628739}
Commits on Aug 3, 2018
Commits on Jul 31, 2018
Commits on May 10, 2018
-
Add CSS for recurrent error message
When an error message has recurred several times, show a message on the interstitial. This CL adds the CSS for the recurrent error message. See https://bugs.chromium.org/p/chromium/issues/detail?id=839969#c3 for a current screenshot. Bug: 839969 Change-Id: I4a3ce380563d7053bf6d241ae18a380f67d22300 Reviewed-on: https://chromium-review.googlesource.com/1052918 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#557513}
Commits on May 9, 2018
-
Show the recurrent error message on the interstitial
When an error message has recurred several times, show a message on the interstitial. Note: the message isn't styled yet; the feature is off by default so I'll do the styling (and translation screenshot) in a follow-up CL. Bug: 839969 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I94a31ff16eaf9e8ef82134f372852f03b19e28df Reviewed-on: https://chromium-review.googlesource.com/1049119 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#557190}
Commits on Apr 24, 2018
Commits on Jan 10, 2018
-
Rotate the interstitial bypass keyword
The security interstitial bypass keyword hasn't changed in two years and awareness of the bypass has been increased in blogs and social media. Rotate the keyword to help prevent misuse. Bug: 797344 Change-Id: I76213b05cc0fe8f23882123d0aeef668652dd89d Reviewed-on: https://chromium-review.googlesource.com/860418 Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#528371}
Commits on Jan 3, 2018
-
Change the interstitial bypass keyword
The security interstitial bypass keyword hasn't changed in two years and awareness of the bypass has been increased in blogs and social media. Rotate the keyword to help prevent misuse. Change-Id: Id3250926afbc98241e9390420ccb68765e618ce6 Bug: 797344 Reviewed-on: https://chromium-review.googlesource.com/843085 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526615}
Commits on Jun 13, 2017
Commits on Jun 8, 2017
-
1) I removed v1 a long time ago. It isn't relevant anymore that some files are v2. 2) This lets us differentiate between loud and quiet interstitials. 3) interstitial_ui.html was named confusingly (it is too similar to the others) so I gave it a more clear name. BUG= Review-Url: https://codereview.chromium.org/2894413003 Cr-Commit-Position: refs/heads/master@{#478096}
