Permalink
Commits on Jan 10, 2019
  1. Prevent IDL code generation of nullable dictionaries as dictionary me…

    acomminos authored and Commit Bot committed Jan 10, 2019
    …mbers.
    
    As per the WebIDL spec, "if the type of the dictionary member, after
    resolving typedefs, is a nullable type, its inner type must not be a
    dictionary type".
    
    Raises an exception when encountering a nullable dictionary type in a
    dictionary. Update the IDL files for Credential Management to the
    upstream version, which removes the nullability of these members.
    
    Bug: 890375
    Change-Id: I179b0193c6c15fc1f51ec10b44a9096d4b3e286a
    Reviewed-on: https://chromium-review.googlesource.com/c/1404411
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Andrew Comminos <acomminos@fb.com>
    Cr-Commit-Position: refs/heads/master@{#621579}
  2. Perform flexbox child hit testing by testing all children atomically

    acomminos authored and Commit Bot committed Jan 10, 2019
    When two child elements of a flexbox overlap (for example, due to
    negative margins), the element drawn in the foreground may not actually
    capture the hit if the element underneath it is hit-tested in an earlier
    phase (e.g. foreground before child block background), despite being
    occluded. This is because painting of flexbox children is done
    atomically (all phases at once). This change makes hit testing atomic as
    well, in accordance with the spec [1].
    
    [1] https://www.w3.org/TR/css-flexbox-1/#painting
    
    Bug: 844505
    Change-Id: Iceab80b42f19488dcb59565ea3c0ce40d48c483b
    Reviewed-on: https://chromium-review.googlesource.com/c/1388206
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Commit-Queue: Andrew Comminos <acomminos@fb.com>
    Cr-Commit-Position: refs/heads/master@{#621516}