Skip to content
Permalink
Branch: master
Commits on Oct 25, 2017
  1. Remove self from OWNERS files

    tgsergeant authored and Commit Bot committed Oct 25, 2017
    I don't work on Chrome/Chromium anymore.
    
    👋
    
    Bug: None
    Change-Id: I98c5a33fd5c92fe0d387e8fd90c479e9d543f58f
    Reviewed-on: https://chromium-review.googlesource.com/735496
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#511408}
Commits on Jul 28, 2017
  1. MD WebUI: Improve accessibility attributes for cr-action-menu

    tgsergeant authored and Commit Bot committed Jul 28, 2017
    This marks up all actions menus with the same accessibility roles across
    all WebUI pages. Menus are now a dialog containing a menu containing a
    list of menu items. This seems to work considerably better than the old
    markup across ChromeVox, VoiceOver and NVDA. The menu is now recognised
    correctly, and we avoid reading out the full list of items twice
    whenever a menu is opened.
    
    Bug: 735808
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I1dd5e706a4073ad4aeab94ac3fabc847aad30a5a
    Reviewed-on: https://chromium-review.googlesource.com/584656
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#490348}
  2. MD Bookmarks: Open bookmark items on middle click.

    tgsergeant authored and Commit Bot committed Jul 28, 2017
    This allows bookmarks to be opened in a new background tab on
    middle-click, or in a new foreground tab on shift middle-click,
    mimicking the behavior of a native link.
    
    Bug: 729856
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I85c81d3a8fb412bccf2fe28874a8e41325c3551c
    Reviewed-on: https://chromium-review.googlesource.com/590393
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#490298}
  3. MD Bookmarks: Add a readme file

    tgsergeant authored and Commit Bot committed Jul 28, 2017
    This readme explains the basics of how the page works, and provides
    links to our design documents.
    
    Bug: 658980
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I4d57849011b30c471c753b236e0f6b724e6acf1b
    Reviewed-on: https://chromium-review.googlesource.com/590390
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#490261}
  4. MD Bookmarks: Scroll and select items that are added to the main list

    tgsergeant authored and Commit Bot committed Jul 28, 2017
    This 'highlights' bookmark items in the following situations:
    * A new item is created in the list
    * Item(s) are pasted into the list
    * Item(s) are dropped into the list
    * 'Show in folder' is selected on a search result
    
    The list of items which will be created is not always known ahead
    of time. Therefore, each time the user performs an action which can
    create items, we track all items that are created and updated, and
    highlight those items once the action has finished processing.
    
    BUG=738958
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2977523002
    Cr-Commit-Position: refs/heads/master@{#490223}
  5. MD Bookmarks: Tweak strings according to UI feedback

    tgsergeant authored and Commit Bot committed Jul 28, 2017
    This changes strings to avoid titlecase, and shortens some strings in
    the bookmark context menu.
    
    Bug: 658980
    Change-Id: Ia173518a481043e8eb79733a5ed0ba9699c4ce22
    Reviewed-on: https://chromium-review.googlesource.com/584695
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#490166}
Commits on Jul 27, 2017
  1. MD Bookmarks: Reenable by default

    tgsergeant authored and Commit Bot committed Jul 27, 2017
    Bug: 658980
    Change-Id: I99d172318c233135d1b5c2f8d433054a09379089
    Reviewed-on: https://chromium-review.googlesource.com/585337
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#489853}
Commits on Jul 26, 2017
  1. MD Bookmarks: Record metrics for commands and keyboard shortcuts

    tgsergeant authored and Commit Bot committed Jul 26, 2017
    This CL adds metrics for whenever a command is handled in the bookmark
    manager, breaking out keyboard shortcuts and recording them separately.
    
    Bug: 665660
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I3ddf5890f899f61e2a3b21e34436bf57819ed6bd
    Reviewed-on: https://chromium-review.googlesource.com/578632
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#489539}
Commits on Jul 21, 2017
  1. MD Bookmarks: Disable by default

    tgsergeant authored and Commit Bot committed Jul 21, 2017
    Bug: 658980
    Change-Id: I6b8bb4d75ac2bf5b122405765a4a4e95d3a7e0d5
    Reviewed-on: https://chromium-review.googlesource.com/580009
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#488529}
Commits on Jul 20, 2017
  1. MD Bookmarks: Disable keyboard shortcuts when a dialog is open

    tgsergeant authored and Commit Bot committed Jul 20, 2017
    Even though our dialogs are modal, it was still possible to execute
    keyboard commands on the background content by clicking on the dialog
    background, which refocuses the document body and allowed commands
    to execute.
    
    Bug: 742972
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I01f9cb3060fd6a91a6fa5a832578f3f245712e0c
    Reviewed-on: https://chromium-review.googlesource.com/575252
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#488116}
  2. MD Bookmarks: Use Command rather than Ctrl as a modifier on Mac

    tgsergeant authored and Commit Bot committed Jul 20, 2017
    It is now possible to command-click to select multiple items, and to use
    command+up/down/space to navigate through the bookmark list. The existing
    shortcut for opening bookmarks with command-down has been removed to
    allow for this.
    
    Bug: 745040
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: Ic37d271e04625aac540af778cf84528131b1787c
    Reviewed-on: https://chromium-review.googlesource.com/575792
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#488084}
Commits on Jul 18, 2017
  1. MD Bookmarks: Announce to screen readers when search results are avai…

    tgsergeant authored and Commit Bot committed Jul 18, 2017
    …lable
    
    Bug: 735808
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I9449bca20368229dbe9c6e4860ad2ba0467fd0d8
    Reviewed-on: https://chromium-review.googlesource.com/567898
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#487413}
Commits on Jul 17, 2017
  1. MD Bookmarks: Replace folder iron-icons with divs with an SVG background

    tgsergeant authored and Commit Bot committed Jul 17, 2017
    MD Bookmarks stamps a large amount of the same folder icon: 1 for every
    node in the sidebar, and 1 for every item in the list. While iron-icon
    is fast as far as Polymer elements go, stamping 50+ of them is still
    expensive.
    
    This CL switches all folder icons across the page to a plain divs that
    have an SVG background. This appears to save at least 5% of page load
    time on profiles with a large number of folders.
    
    Bug: 727177
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I439f83ad3c3f645108d1a3d744cce2e402acbcee
    Reviewed-on: https://chromium-review.googlesource.com/566264
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#487028}
Commits on Jul 14, 2017
  1. MD Bookmarks: Add 'show in folder' command to search result context menu

    tgsergeant authored and Commit Bot committed Jul 14, 2017
    BUG=727174
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2962283002
    Cr-Commit-Position: refs/heads/master@{#486678}
Commits on Jul 12, 2017
  1. MD Bookmarks: Lazily render sidebar tree descendants

    tgsergeant authored and Commit Bot committed Jul 12, 2017
    This makes stamping folder trees with closed folders significantly
    faster, without making any noticeable impact on fully-open trees.
    
    Bug: 727177
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I087898598b265a396aeb6e178487ee8a5ece8d5a
    Reviewed-on: https://chromium-review.googlesource.com/566205
    Reviewed-by: Christopher Lam <calamity@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#485921}
Commits on Jul 11, 2017
  1. MD WebUI: Clear cr-action-menu focus state on mouseover on a disabled…

    tgsergeant authored and Commit Bot committed Jul 11, 2017
    … menu item
    
    Bug: 732675
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I1cb5f217d063c192d45d0ebeb2da07980f852e5f
    Reviewed-on: https://chromium-review.googlesource.com/562900
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#485485}
Commits on Jul 6, 2017
  1. MD Bookmarks: Always select targeted item during doubleclick

    tgsergeant authored and Commit Bot committed Jul 6, 2017
    This CL fixes an issue where a double click while a menu was showing
    would open the selection rather than what was clicked. This now selects
    and opens the doubleclicked item instead.
    
    BUG=731004
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2972773003
    Cr-Commit-Position: refs/heads/master@{#484516}
  2. MD Bookmarks: Prevent flash of folder contents when changing search term

    tgsergeant authored and Commit Bot committed Jul 6, 2017
    In MD Bookmarks, changing search term would clear the results of the
    current search, then fire off a new search request, which would bring in
    new results <1 second later. This caused a brief flash of folder contents
    for whatever folder was currently selected.
    
    This CL fixes that issue by holding on to the old search results until
    the new search results are available.
    
    BUG=737076
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2972963003
    Cr-Commit-Position: refs/heads/master@{#484494}
  3. MD Bookmarks: Fix Meta-down not triggering the 'Open' command on Mac

    tgsergeant authored and Commit Bot committed Jul 6, 2017
    This keyboard shortcut was instead being handled by the main bookmark
    list.
    
    BUG=738296
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2964883002
    Cr-Commit-Position: refs/heads/master@{#484484}
  4. MD Bookmarks: Remove '/?id=1' from URL when displaying Bookmarks Bar

    tgsergeant authored and Commit Bot committed Jul 6, 2017
    This changes the default URL for MD Bookmarks to 'chrome://bookmarks',
    like the previous bookmark manager. Upon navigating to a different
    folder or performing a search, the URL will update as expected.
    
    BUG=658980
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2960143002
    Cr-Commit-Position: refs/heads/master@{#484481}
Commits on Jul 5, 2017
  1. MD Bookmarks: Always use a two-way arrow cursor for resizing the sidebar

    tgsergeant authored and Commit Bot committed Jul 5, 2017
    This changes the cursor on the sidebar to 'e-resize' on Windows and
    'col-resize' on other platforms, which results in always showing a
    two-way arrow.
    
    This matches the behavior of the old bookmark manager on Windows and
    Mac, while Linux (Ubuntu, at least) changes from a one-way arrow to
    a two-way arrow.
    
    BUG=737153
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2970793002
    Cr-Commit-Position: refs/heads/master@{#484225}
Commits on Jul 4, 2017
  1. MD Bookmarks: Add full support for cut/copy/paste keyboard shortcuts

    tgsergeant authored and Commit Bot committed Jul 4, 2017
    This adds keyboard shortcuts for Cut/Paste, and expands the keyboard
    shortcut for Copy to work with any selection (not just a single
    bookmark).
    
    Copying a bookmark shows a toast indicating how many items were copied,
    since there is no other visual indicator that the copy was successful.
    
    BUG=729858
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2948943002
    Cr-Commit-Position: refs/heads/master@{#484043}
Commits on Jul 3, 2017
  1. MD Bookmarks: Initial screenreader accessibility improvements

    tgsergeant authored and Commit Bot committed Jul 3, 2017
    This is an initial set of small improvements to screenreader
    accessibility in MD Bookmarks. In particular,
    
    - Marks up the sidebar tree, list and menus with correct roles
    - Adds labels to menu buttons
    - Hides the toast message from screenreaders when it is off screen
    
    These changes have been tested with ChromeVox only.
    
    BUG=735808
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2955563002
    Cr-Commit-Position: refs/heads/master@{#483955}
Commits on Jun 30, 2017
  1. MD History: Fix text selection in history items

    tgsergeant authored and Commit Bot committed Jun 30, 2017
    Clicking on a history item would immediately change focus if the item
    wasn't selected, preventing selection with the mouse. This fixes the
    issue by preventing the extra unnecessary change of focus.
    
    BUG=675058
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2962103002
    Cr-Commit-Position: refs/heads/master@{#483632}
  2. MD History: Update timestamp hover text when item changes

    tgsergeant authored and Commit Bot committed Jun 30, 2017
    This fixes an issue where the time title would be stuck on the first
    value it was set to, never updating as the list was scrolled and
    changed.
    
    The end result is that the code matches patchset 2 of
    https://codereview.chromium.org/2454303002/.
    
    BUG=675056
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2962133002
    Cr-Commit-Position: refs/heads/master@{#483630}
  3. MD History: Reset scroll position when displaying new results

    tgsergeant authored and Commit Bot committed Jun 30, 2017
    BUG=722618
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2965463002
    Cr-Commit-Position: refs/heads/master@{#483562}
Commits on Jun 28, 2017
  1. MD Bookmarks: Batch updates to the UI when processing API operations

    tgsergeant authored and Commit Bot committed Jun 28, 2017
    In MD Bookmarks, each action processed from the bookmarks API listeners
    would immediately notify the UI about changes that need to be made. In
    cases where many notifications are triggered in a row (eg, deleting 100
    bookmarks), this would cause many useless UI updates, slowing the page
    down significantly.
    
    This CL adds a 'batch mode' to the data store which suppresses UI
    notifications while it is active. Enabling batch mode for API operations
    (move, add, delete) makes these >10x faster with large numbers of nodes.
    
    BUG=727177
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2946203002
    Cr-Commit-Position: refs/heads/master@{#482838}
Commits on Jun 26, 2017
  1. MD Bookmarks: Add a confirmation dialog before opening many tabs

    tgsergeant authored and Commit Bot committed Jun 26, 2017
    BUG=731486
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2945513002
    Cr-Commit-Position: refs/heads/master@{#482202}
Commits on Jun 23, 2017
  1. MD Bookmarks: Deselect items when they are moved to a new folder

    tgsergeant authored and Commit Bot committed Jun 23, 2017
    This fixes an issue where the multi-select toolbar would still appear
    after the selected items had been moved to a different folder.
    
    BUG=697706
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2946883002
    Cr-Commit-Position: refs/heads/master@{#481749}
Commits on Jun 22, 2017
  1. MD Bookmarks: Fix spacing in the toast popup when deleting bookmarks

    tgsergeant authored and Commit Bot committed Jun 22, 2017
    This prevents unnecessary spacing when deleting bookmarks with short
    names.
    
    BUG=733046
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2948953002
    Cr-Commit-Position: refs/heads/master@{#481454}
  2. MD Bookmarks: Lazily render dropdown menus

    tgsergeant authored and Commit Bot committed Jun 22, 2017
    This defers rendering the dropdown menus from the toolbar and command
    manager until they are actually needed. This saves a small amount of time
    (~10ms) during page load.
    
    BUG=727177
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2940233003
    Cr-Commit-Position: refs/heads/master@{#481425}
Commits on Jun 21, 2017
  1. MD WebUI: Support dynamically added menu items in cr-action-menu

    tgsergeant authored and Commit Bot committed Jun 20, 2017
    The cr-action-menu element previously cached its child elements during
    attached. This was causing errors in MD Bookmarks, which has a
    action-menu which stamps its children in a dom-repeat (which will happen
    asynchronously after attached).
    
    This CL removes the cache so that cr-action-menu checks its children
    during keyboard navigation. This allows items to be added and removed
    dynamically while preserving correct keyboard navigation.
    
    Bug: 729939
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I5b438d06a1e711c3f943b17d0e495ef557eec5c7
    Reviewed-on: https://chromium-review.googlesource.com/528033
    Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#481099}
Commits on Jun 16, 2017
  1. MD Bookmarks: Make shortcuts for select all/deselect all global

    tgsergeant authored and Commit Bot committed Jun 16, 2017
    These shortcuts (Ctrl/Meta-A and Escape) can now be triggered while
    the sidebar or document are active.
    
    BUG=730405
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2929053004
    Cr-Commit-Position: refs/heads/master@{#479975}
  2. MD Bookmarks: Add right-click context menu to sidebar folders

    tgsergeant authored and Commit Bot committed Jun 16, 2017
    Right clicking a folder in the sidebar will select that folder and
    show the menu of edit/open commands for that folder.
    
    BUG=692837
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2926233002
    Cr-Commit-Position: refs/heads/master@{#479957}
  3. MD Bookmarks: Fix issue where keyboard shortcuts could fire incorrectly

    tgsergeant authored and Commit Bot committed Jun 16, 2017
    MD Bookmarks did not correctly distinguish between a keypress of 'Enter'
    vs 'Shift-Enter', meaning that someone trying to 'Open in new window'
    could instead 'Edit' or 'Open', depending on platform.
    
    This fixes the issue by moving shortcut handling from iron-a11y-keys
    to using the standard WebUI Command handlers.
    
    BUG=731531
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2939873004
    Cr-Commit-Position: refs/heads/master@{#479940}
Older
You can’t perform that action at this time.