From 2ab5e7d4e0ac07efc8e4110cea3b843ae174af84 Mon Sep 17 00:00:00 2001 From: Paul Dicker Date: Mon, 12 Feb 2024 18:46:33 +0100 Subject: [PATCH 1/3] Use `TimeDelta` instead of `Duration` alias --- src/offset/local/windows.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/offset/local/windows.rs b/src/offset/local/windows.rs index cee09eca8b..df29430e42 100644 --- a/src/offset/local/windows.rs +++ b/src/offset/local/windows.rs @@ -184,7 +184,7 @@ mod tests { use crate::offset::local::win_bindings::{ SystemTimeToFileTime, TzSpecificLocalTimeToSystemTime, FILETIME, SYSTEMTIME, }; - use crate::{DateTime, Duration, FixedOffset, Local, NaiveDate, NaiveDateTime}; + use crate::{DateTime, FixedOffset, Local, NaiveDate, NaiveDateTime, TimeDelta}; use crate::{Datelike, TimeZone, Timelike}; use std::mem::MaybeUninit; use std::ptr; @@ -256,7 +256,7 @@ mod tests { if let Some(our_result) = Local.from_local_datetime(&date).earliest() { assert_eq!(from_local_time(&date), our_result); } - date += Duration::hours(1); + date += TimeDelta::hours(1); } } } From a100b014a558af2889519b2ca055b16e70846b39 Mon Sep 17 00:00:00 2001 From: Paul Dicker Date: Mon, 12 Feb 2024 18:47:23 +0100 Subject: [PATCH 2/3] Fix clippy warning --- src/offset/local/windows.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/offset/local/windows.rs b/src/offset/local/windows.rs index df29430e42..de48f0653c 100644 --- a/src/offset/local/windows.rs +++ b/src/offset/local/windows.rs @@ -103,7 +103,7 @@ pub(super) fn offset_from_local_datetime(local: &NaiveDateTime) -> LocalResult return LocalResult::Single(tz_info.std_offset), + (None, None) => LocalResult::Single(tz_info.std_offset), } } From 92c227e2a4075eef55fa36eae611e3de1dc0def3 Mon Sep 17 00:00:00 2001 From: Paul Dicker Date: Wed, 14 Feb 2024 13:49:10 +0100 Subject: [PATCH 3/3] Run clippy also against Windows target --- .github/workflows/lint.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 3e06ad3209..b0917746ce 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -25,6 +25,9 @@ jobs: - run: | cargo clippy ${{ env.ALL_NON_EXCLUSIVE_FEATURES }} --all-targets --color=always \ -- -D warnings + - run: | + cargo clippy --target=x86_64-pc-windows-msvc --all-targets --color=always \ + -- -D warnings - run: | cargo clippy --manifest-path fuzz/Cargo.toml --color=always \ -- -D warnings