Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline test_encodable_json and test_decodable_json functions #1550

merged 4 commits into from
Apr 4, 2024


Copy link

The test_encodable_json and test_decodable_json functions in the modules of NaiveDate, NaiveTime, NaiveDateTime and DateTime used to help testing the serde and rustc-serialize implementations.

Now that we only have serde we can inline them in into the tests.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (6c4e735) to head (767ede6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1550      +/-   ##
- Coverage   91.79%   91.79%   -0.01%     
  Files          37       37              
  Lines       18185    18175      -10     
- Hits        16693    16683      -10     
  Misses       1492     1492              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@pitdicker pitdicker merged commit ffe2745 into chronotope:main Apr 4, 2024
35 checks passed
@pitdicker pitdicker deleted the test_json branch April 4, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants