Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ex-info for varity specific exception #20

Merged
merged 1 commit into from Nov 13, 2018
Merged

Conversation

totakke
Copy link
Member

@totakke totakke commented Nov 7, 2018

ex-info is more useful for catch side in some cases such as debugging or dispatch.

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #20 into master will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage      39%   38.99%   -0.02%     
==========================================
  Files          13       13              
  Lines        1446     1467      +21     
  Branches       31       31              
==========================================
+ Hits          564      572       +8     
- Misses        851      864      +13     
  Partials       31       31
Impacted Files Coverage Δ
src/varity/vcf_to_hgvs/protein.clj 28.57% <0%> (ø) ⬆️
src/varity/hgvs_to_vcf/protein.clj 10.14% <0%> (ø) ⬆️
src/varity/vcf_to_hgvs/cdna.clj 26.36% <0%> (ø) ⬆️
src/varity/vcf_to_hgvs.clj 15.09% <0%> (-1.24%) ⬇️
src/varity/hgvs_to_vcf.clj 25.42% <0%> (-0.44%) ⬇️
src/varity/vcf_to_hgvs/common.clj 66.88% <90.9%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b6775...67bfa51. Read the comment docs.

Copy link
Member

@federkasten federkasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️ This changes are helpful for me too.

@federkasten federkasten merged commit 961f75b into master Nov 13, 2018
@federkasten federkasten deleted the fix/ex-info branch November 13, 2018 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants