Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to GTK+3 and Python3 #1

Closed
wants to merge 29 commits into from

Conversation

Projects
None yet
2 participants
@actionless
Copy link
Contributor

commented Jan 19, 2019

No description provided.

chrysn and others added some commits Mar 11, 2010

Version 0.1.3
* Prevent too large window size requests
* New translations:
  - Italian (by Quizzlo)
  - Brasilian (by Phantom X)
  - Danish (by Joe Hansen)
  - Kannada (by gundachandru)
* Better translation infrastructure
  - Translations now hosted on https://transifex.net/projects/p/arandr/
* man page enhancements
  - man page generation now depends on docutils (>=0.6)
* New source code repository at http://gitorious.org/arandr/arandr
Version 0.1.4
* This is a bugfix / translation update release
* Fix for "unknown connection" bug
* New translations:
  - Russian (by HsH)
  - French (by Clément Démoulins)
  - Polish (by RooTer)
  - Arabic (by Mohammad Alhargan)
  - Turkish (by Mehmet Gülmen)
  - Spanish (by Ricardo A. Hermosilla Carrillo)
  - Catalan (by el_libre)
  - Chinese (by Carezero)
* Translation updates:
  - Danish
  - Brazilian
  - Arabic (by aboodilankaboot)
Version 0.1.5
* New unxrandr tool
* New translations:
  - Dutch (by wimfeijen)
  - Romanian (by sjb and Себастьян Gli ţa Κατινα)
  - Slovak (by Slavko)
  - Persian (by Alireza Savand)
* Updated translations:
  - French (by Bruno Patri)
* Added copyright headers to all source files
Version 0.1.6
* New translations:
  - Breton (by Belvar)
  - Lithunian (by Algimantas Margevičius)
  - Galician (by Miguel Anxo Bouzada)
  - Japanese (by o-157)
  - Swedish (by Ingemar Karlsson)
  - Bosnian (by Semsudin Abdic)
* Updated translations:
  - Persian (by Alireza Savand)
  - Spanish (by Miguel Anxo Bouzada)
* Minor bugfixes
Version 0.1.7
* Fix the 'primary' issue
  - ignores the primary keyword
  - makes ARandR compatible with xrandr 1.4.0
* Merged parts of the cglita branch
  - solves ValueError / "1080p" issue
* New translations:
  - Ukrainian (by Rax Garfield)
  - Hungarian (by Tamás Nagy)
  - Greek (by Dimitris Giouroukis)
  - Korean (by ParkJS)
* Updated translations:
  - Lithuanian (by Mantas Kriaučiūnas)
Version 0.1.7.1
* Build even with no translations present
* Fix AttributeError when modes with same name have different resolutions
* Show the entire output submenu as disabled instead of the "Active" checkbox
Version 0.1.8
* Allow setting the primary output
* New translations:
  - Sardinian (by Lu Ca)
  - Estonian (by Kristjan Räts)
  - Czech (by Michal Čihař)
* Updated translations
  - Brazilian (by Fred Maranhão)
  - Russian (by Ivan Vantu5z)
  - French (by Tuux)
  - Polish (by Piotr Strebski)
  - Persian (by reza khan)
  - Ukrainian (by Igor)
  - Hungarian (by Balázs Úr)
  - Greek (by Efstathios Iosifidis)
  - Korean (by cho bkwon)
Version 0.1.9
* Support xrandr 1.5.0
* New translations:
  - Albanian
* Updated translations

@actionless actionless changed the base branch from release to master Jan 19, 2019

@actionless actionless force-pushed the actionless:master branch from fa55606 to b65a930 Jan 19, 2019

@chrysn

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2019

Thanks for your efforts, I'm just not quite sure how to proceed with this -- as it's based on the maintenance branch of the old ARandR versions (master ... and release?), I can't easily merge any of this into the branch where actual development is happening (and, moreover, the GTK3 and Python3 transitions have been completed).

From a rough review[1] I'd say that this branch is in a good state to point distros to that can't wait for ARandR 0.2 but would otherwise need to drop ARandR from their repos when dropping GTK/Python2.

I'd very much welcome you to join development of ARandR at GitLab where the actual development is taking place and issues are being tracked; the branch is still in an odd shape after refactoring (loading and saving don't work, and the context menus are just growing back), but offers a much more modern codebase.

[1]: A full one is not quite trivial as the commits sometimes mix Python3 porting with whitespace cleanup, whitespace style adaption and renaming of the terribly short variable names I chose -- all by themselves worthy goals, but easier to review when separated by type.

@actionless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2019

the branch is still in an odd shape after refactoring (loading and saving don't work, and the context menus are just growing back

i think that's already solved in my PR.
have you tried running it?

@actionless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2019

all by themselves worthy goals, but easier to review when separated by type.

i was not able to proceed with refactoring when most of the vars were named a, b, c

@actionless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2019

btw if you're not aware of git diff -b -w nowadays github allows to filter out whitespace changes even in the Web UI for PR reviews

layout.set_attributes(attrs)

layout.set_text(on)
underline_attrs = Pango.parse_markup("<u>test</u>", -1, "0")[1]

This comment has been minimized.

Copy link
@actionless

actionless Jan 19, 2019

Author Contributor

this is the only part of my port which i'm not proud of, i spend more than 10 minutes but didn't got Underline Attribute to work in other way than this (i worked with cairo and gtk before, but almost not touched pango directly)

@chrysn

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2019

@actionless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2019

that particular commit indeed should be reviewed with -b -w, however the rest of commits are separated (ie have a look on commit names, pylint and porting commits all other are separated)

@chrysn

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2019

@chrysn

This comment has been minimized.

Copy link
Owner

commented Jan 19, 2019

I'm rebasing the commits to set the branch structure right and doing some other cleanup (like bending shebangs to python3). Given the nontrivial changes I'd add you to the copyright notes – is it just "actionless"?

@actionless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2019

and also after rebasing let me know if any extra gtk-related stuff remains to be adjusted (as i understood new options are added to context menus and smth need to be done there?). i think we could solve releasing python3/gtk3 port incorporating additional xrandr options in next few days without a problem

and also if you're going to archive github repo it's not a problem to continue remaining fixes on gitlab

(my next project will be porting nitrogen to gtkmm3 :-) themix-project/oomox-gtk-theme#45 )

as about name: it depends how other contributors are listed, if by real names, it also available in my github profile

chrysn added a commit that referenced this pull request Jan 21, 2019

@chrysn

This comment has been minimized.

Copy link
Owner

commented Jan 21, 2019

I've merged your changes into master after rebasing them; merge is in da0ebac. The underline hack was replaced in b3fe73e.

There remain two small regressions (a gdk-critical message that is actually just a warning about an unknown atom (gdk_atom_intern: assertion 'atom_name != NULL' failed) and the background for large windows / small virtuals not being black any more, but I won't bother given the main development branch.

With other merges (README updates and translations pulled in), I'll publish this as 0.10 after some more testing (other devices). Thanks for your input!

@chrysn chrysn closed this Jan 21, 2019

@actionless

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

should i look into some of the issues?

thanks a lot of cleaning it up for merging! and sorry for confusion regarding git hostings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.