Refactoring out the split() on the string per @marcoceppi

chuckbutler · f19a0c67d6af5c9e2644451543b32838390d52e9 · chuckbutler committed Jan 12, 2016 · Jan 12, 2016 · f19a0c6
1 parent 5a1b4f2
commit f19a0c67d6af5c9e2644451543b32838390d52e9
Unified Split

Showing with 2 additions and 2 deletions.

+2 −2 charms/docker/__init__.py
diff --git a/charms/docker/__init__.py b/charms/docker/__init__.py
@@ -49,5 +49,5 @@ def run(self, image, options="", volumes=[], ports=[]):
             print("Error: ", expect.returncode, expect.output)
 
     def login(self, user, password, email):
-        cmd = "docker login -u {0} -p {1} -e {2}".format(user, password, email)
-        subprocess.check_call(split(cmd))
+        cmd = [ 'docker', 'login', '-u', user, '-p', password', '-e', email]
+        subprocess.check_call(cmd)