New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit and integration tests - are they used? #243

Closed
erikbra opened this Issue Feb 16, 2016 · 9 comments

Comments

Projects
None yet
3 participants
@erikbra
Member

erikbra commented Feb 16, 2016

I have a WIP issue #187, but I would love to be able to run some tests before trying to submit a pull request again. However, tooling for MBUnit is far from ideal. I have not been able to find any plugin that works with VS2015, neither for Resharper or pure runner (TestDriven.Net doesn't seem to work anymore). I don't feel very comfortable not being able to run tests.

  1. Are there any MBUnit runners for VIsual Studio 2015? Or command-line/gui?
  2. Would it be an idea to consider moving to a more actively developed test framework, e.g. NUnit, XUnit, MSTest, etc?

I really love RoundhousE, and use it in production with success. I just fear depending on dying(?) frameworks could be a hindrance going forward. Opinions or tips?

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Feb 17, 2016

Member

We were looking at one point at converting all of the tests over to NUnit/TinySpec framework. If you are interested, look at DropKick or Chocolatey's tests and you can see how it is somewhat similar with less magic involved.

You can run the tests from the command line by typing test and test all

Member

ferventcoder commented Feb 17, 2016

We were looking at one point at converting all of the tests over to NUnit/TinySpec framework. If you are interested, look at DropKick or Chocolatey's tests and you can see how it is somewhat similar with less magic involved.

You can run the tests from the command line by typing test and test all

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Jun 12, 2017

Member

If I should have any hope on working a bit on RoundhousE, I need a working test suite that can be run in Visual Studio. Do you know, @ferventcoder, if there are any active efforts to convert to a more actively developed testing framework, or should I just have a go at it? I have experience from day-job with xUnit and e.g. FluentAssertions, and no experience with TinySpec. Do you have a strong opinion on this? I just feel that if more "main-line" test and assert frameworks are not adopted, it will be difficult to get new contributors to engage. But, I might of course be biased from my current experience.

Do you have any strong opinions against converting to e.g. xUnit or NUnit? I havent looked at all the tests, and I think MBUnit is way more BDD-style than these two, but with the help of e.g. FluentAssertions, maybe we could make the porting not too intrusive.

Member

erikbra commented Jun 12, 2017

If I should have any hope on working a bit on RoundhousE, I need a working test suite that can be run in Visual Studio. Do you know, @ferventcoder, if there are any active efforts to convert to a more actively developed testing framework, or should I just have a go at it? I have experience from day-job with xUnit and e.g. FluentAssertions, and no experience with TinySpec. Do you have a strong opinion on this? I just feel that if more "main-line" test and assert frameworks are not adopted, it will be difficult to get new contributors to engage. But, I might of course be biased from my current experience.

Do you have any strong opinions against converting to e.g. xUnit or NUnit? I havent looked at all the tests, and I think MBUnit is way more BDD-style than these two, but with the help of e.g. FluentAssertions, maybe we could make the porting not too intrusive.

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Jun 12, 2017

Member

@erikbra Chocolatey's test suite has that ability - and also the documentation is getting more comprehensive, see https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#debugging--testing

Member

ferventcoder commented Jun 12, 2017

@erikbra Chocolatey's test suite has that ability - and also the documentation is getting more comprehensive, see https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#debugging--testing

erikbra pushed a commit to erikbra/roundhouse that referenced this issue Jun 13, 2017

erikbra pushed a commit to erikbra/roundhouse that referenced this issue Jun 13, 2017

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Jun 13, 2017

Member

I made a pull request where I converted all the MBUnit tests to xUnit. Could you please have a look at it when you have some time?

"Converted all tests from MBUnit to xUnit" #271

Member

erikbra commented Jun 13, 2017

I made a pull request where I converted all the MBUnit tests to xUnit. Could you please have a look at it when you have some time?

"Converted all tests from MBUnit to xUnit" #271

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Jun 13, 2017

Member

NUnit was the hope here.

Member

ferventcoder commented Jun 13, 2017

NUnit was the hope here.

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Jun 13, 2017

Member

Yes, sorry about that. I'll convert to NUnit if you prefer, but I couldn't find a good substitute for the Observation attribute in NUnit. Are you aware of any?

Member

erikbra commented Jun 13, 2017

Yes, sorry about that. I'll convert to NUnit if you prefer, but I couldn't find a good substitute for the Observation attribute in NUnit. Are you aware of any?

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Jun 14, 2017

Member

I am going to defer the decision on the switch to @BiggerNoise. As far as substitutes - did you spend any time looking over choco's source code? It's very similar to what you achieved and tinyspec is what allows for fact/observation attributes as an inheritor of the test attribute.

Member

ferventcoder commented Jun 14, 2017

I am going to defer the decision on the switch to @BiggerNoise. As far as substitutes - did you spend any time looking over choco's source code? It's very similar to what you achieved and tinyspec is what allows for fact/observation attributes as an inheritor of the test attribute.

erikbra added a commit to erikbra/roundhouse that referenced this issue Jun 14, 2017

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Jun 17, 2017

Member

Sorry, I haven't had the chance to look through choco's source code in detail yet. I will, though. And, if it's a point to keep them similar, I can try to align the changes in RoundhousE with the looks of choco. Is master the best branch to look at?

Member

erikbra commented Jun 17, 2017

Sorry, I haven't had the chance to look through choco's source code in detail yet. I will, though. And, if it's a point to keep them similar, I can try to align the changes in RoundhousE with the looks of choco. Is master the best branch to look at?

erikbra added a commit to erikbra/roundhouse that referenced this issue Jun 19, 2017

Issue #243: Converted MBunit tests to NUnit.
Using Moq and Should for assertions, to be closer to what Chocolatey
does. Compare this with Pull request #271, which uses xUnit,
NSubstitute and FluentAssertions

erikbra added a commit to erikbra/roundhouse that referenced this issue Aug 7, 2017

Issue #243: Converted MBunit tests to NUnit.
Using Moq and Should for assertions, to be closer to what Chocolatey
does. Compare this with Pull request #271, which uses xUnit,
NSubstitute and FluentAssertions
@BiggerNoise

This comment has been minimized.

Show comment
Hide comment
@BiggerNoise

BiggerNoise Oct 11, 2017

Member

Thank you for the P/R on this

Member

BiggerNoise commented Oct 11, 2017

Thank you for the P/R on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment