Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Dependencies on RoundhousE.lib #365

Closed
BlythMeister opened this Issue Feb 6, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@BlythMeister
Copy link
Contributor

BlythMeister commented Feb 6, 2019

The nuget listing states:

image

However many of the other required dependencies for the instances are not lised.

As a result, when using roundhouse.lib without adding any other dependencies manually, you get a runtime error:

Exception has been thrown by the target of an invocation.
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.Reflection.ConstructorInfo.Invoke(Object[] parameters)
   at roundhouse.infrastructure.loaders.DefaultInstanceCreator.create_object_from_string_type(String object_to_create)
   at roundhouse.infrastructure.loaders.DefaultInstanceCreator.create_object_from_string_type[T](String object_to_create)
   at roundhouse.infrastructure.app.builders.DatabaseBuilder.build(FileSystemAccess file_system, ConfigurationPropertyHolder configuration_property_holder)
   at roundhouse.infrastructure.app.ApplicationConfiguraton.build_items_for_container(ConfigurationPropertyHolder configuration_property_holder)
   at roundhouse.infrastructure.app.ApplicationConfiguraton.build_the_container(ConfigurationPropertyHolder configuration_property_holder)
   at roundhouse.Migrate.GetMigrationRunner()
   at roundhouse.Migrate.Run()
@erikbra

This comment has been minimized.

Copy link
Member

erikbra commented Feb 6, 2019

You are definitely right. There has been some ILMerge-ing of the roundhouse.lib. It's starting to cause problems by itself too, I am considering skipping the whole ILMerge thing, and in the process the nuget package dependencies will be solved too. Thanks for reporting!

@erikbra erikbra self-assigned this Feb 6, 2019

@erikbra erikbra added Bug v1.0.4 labels Feb 6, 2019

@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented Feb 7, 2019

I've never understood the need to ilmerge these days.
Nuget handles dependencies well when specified correctly ,🙂

BlythMeister added a commit to BlythMeister/roundhouse that referenced this issue Feb 7, 2019

Update nuspec to match the dependencies needed
This is taken from the project filess used in roundhouse.lib.merged

Fixes chucknorris#365
@BlythMeister

This comment has been minimized.

Copy link
Contributor Author

BlythMeister commented Feb 7, 2019

@erikbra i've raised a PR updating the nuspec to include the missing dependencies :)

@erikbra erikbra closed this in #367 Feb 8, 2019

erikbra added a commit that referenced this issue Feb 8, 2019

Update nuspec to match the dependencies needed (#367)
This is taken from the project filess used in roundhouse.lib.merged

Fixes #365

@erikbra erikbra added the 3 - Done label Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.