New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SQL Server CE with feedback from ferventcoder. #139

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@eavonius

eavonius commented Feb 2, 2014

Supersedes #133.

Rob, I'm creating this with what I have now. It's from a different branch as you suggested (sorry about that). I'm looking for a couple replies on comments with the previous PR, when I handle those I'll fix those issues and update this, at which point we can nuke the old one.

Thanks for your help.

@ErikEJ

This comment has been minimized.

Show comment
Hide comment
@ErikEJ

ErikEJ Apr 12, 2016

Contributor

@ferventcoder Anything I can do to get this PR accepted? Create a new one??
It would be a great addition to the tool, and I have frequent request for how to solve the issue that RoundhousE deals with,

Contributor

ErikEJ commented Apr 12, 2016

@ferventcoder Anything I can do to get this PR accepted? Create a new one??
It would be a great addition to the tool, and I have frequent request for how to solve the issue that RoundhousE deals with,

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Apr 12, 2016

Member

@ErikEJ I think creating a new PR would shepherd this along. This one was pretty good but will need updates.

Member

ferventcoder commented Apr 12, 2016

@ErikEJ I think creating a new PR would shepherd this along. This one was pretty good but will need updates.

@BiggerNoise

This comment has been minimized.

Show comment
Hide comment
@BiggerNoise

BiggerNoise Oct 9, 2017

Member

@ferventcoder What, specifically, needs to be updated to pull this in? To clear the backlog, I'm letting minor stylistic stuff slide, but if something is really off, I don't want to pull it in in haste.

Member

BiggerNoise commented Oct 9, 2017

@ferventcoder What, specifically, needs to be updated to pull this in? To clear the backlog, I'm letting minor stylistic stuff slide, but if something is really off, I don't want to pull it in in haste.

@eavonius

This comment has been minimized.

Show comment
Hide comment
@eavonius

eavonius Oct 10, 2017

Feel free to go nuts with tweaking this PR, it's so old I barely remember what I did here (probably nothing stellar). Thanks for catching up on all these old PRs!

eavonius commented Oct 10, 2017

Feel free to go nuts with tweaking this PR, it's so old I barely remember what I did here (probably nothing stellar). Thanks for catching up on all these old PRs!

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Oct 10, 2017

Member

Honestly I'm not sure what needs to be done. But I like the general direction of this so I'm game for pulling it in and then making adjustments.

Member

ferventcoder commented Oct 10, 2017

Honestly I'm not sure what needs to be done. But I like the general direction of this so I'm game for pulling it in and then making adjustments.

@ErikEJ

This comment has been minimized.

Show comment
Hide comment
@ErikEJ

ErikEJ Oct 10, 2017

Contributor

Happy to contribute any "adjustments" once it is in!

Contributor

ErikEJ commented Oct 10, 2017

Happy to contribute any "adjustments" once it is in!

@BiggerNoise

This comment has been minimized.

Show comment
Hide comment
@BiggerNoise

BiggerNoise Oct 10, 2017

Member

Excellent. I'll try and get it pulled in tonight.

Member

BiggerNoise commented Oct 10, 2017

Excellent. I'll try and get it pulled in tonight.

@ErikEJ

This comment has been minimized.

Show comment
Hide comment
@ErikEJ

ErikEJ Oct 10, 2017

Contributor

Nice to get this done 3 years before extended support stops!

Contributor

ErikEJ commented Oct 10, 2017

Nice to get this done 3 years before extended support stops!

@BiggerNoise

This comment has been minimized.

Show comment
Hide comment
@BiggerNoise

BiggerNoise Oct 11, 2017

Member

OK. I'm in a bit of a pickle on this one. The original repository is gone and github is not allowing me to download the patch.

I'll cycle back eventually, but it would really grease the skids if someone could recreate the P/R so I can merge it in. I think if you can just reproduce the work here, I can merge without much difficulty. There's supposed to be a merge conflict on the solution, but I can get through that easily enough.

Member

BiggerNoise commented Oct 11, 2017

OK. I'm in a bit of a pickle on this one. The original repository is gone and github is not allowing me to download the patch.

I'll cycle back eventually, but it would really grease the skids if someone could recreate the P/R so I can merge it in. I think if you can just reproduce the work here, I can merge without much difficulty. There's supposed to be a merge conflict on the solution, but I can get through that easily enough.

@ErikEJ

This comment has been minimized.

Show comment
Hide comment
@ErikEJ

ErikEJ Oct 11, 2017

Contributor

@BiggerNoise You mean reconstruct the PR and resubmit? In that case I am game... (with the hope of actually getting it in)

Contributor

ErikEJ commented Oct 11, 2017

@BiggerNoise You mean reconstruct the PR and resubmit? In that case I am game... (with the hope of actually getting it in)

ErikEJ added a commit to ErikEJ/roundhouse that referenced this pull request Oct 11, 2017

@ErikEJ

This comment has been minimized.

Show comment
Hide comment
@ErikEJ

ErikEJ Oct 11, 2017

Contributor

PR submitted 😄

Contributor

ErikEJ commented Oct 11, 2017

PR submitted 😄

@BiggerNoise

This comment has been minimized.

Show comment
Hide comment
@BiggerNoise

BiggerNoise Oct 11, 2017

Member

Superseded by #277

Member

BiggerNoise commented Oct 11, 2017

Superseded by #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment