New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push to MyGet from AppVeyor builds #301

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@erikbra
Member

erikbra commented Nov 12, 2017

Add a step to push to MyGet from the AppVeyor builds. Uses encryptet MyGet ApiKey (needs to be inserted, of course), using https://ci.appveyor.com/tools/encrypt. It encrypts with a unique key per AppVeyor account.

It would be really nice if AppVeyor supported merging of AppVeyor.yml and GUI, because then we could put the URI to the MyGet feed (which varies for e.g. erikbra and roundhouse) and the Api Key in the GUI instead of the checked-in file. But it does the job.

This only pushes "proper" builds (not builds of PRs). So we would push (of course with a -pre tag if #300 is merged too) whenever master is built on its own, but not on PR builds.

@BiggerNoise

This comment has been minimized.

Show comment
Hide comment
@BiggerNoise

BiggerNoise Nov 13, 2017

Member

This is WiP (more or less) until we can get an API key for MyGet, correct?

@ferventcoder - Do you want one of us to establish a MyGet account and send you the credentials privately, or do you want to do it and fill in the blanks in this P/R?

Member

BiggerNoise commented Nov 13, 2017

This is WiP (more or less) until we can get an API key for MyGet, correct?

@ferventcoder - Do you want one of us to establish a MyGet account and send you the credentials privately, or do you want to do it and fill in the blanks in this P/R?

@ferventcoder ferventcoder changed the title from Add push to MyGet from AppVeyor builds to {WIP} Add push to MyGet from AppVeyor builds Nov 13, 2017

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Nov 13, 2017

Member

I tried to register RoundhousE on MyGet, but it was already taken. (ref https://www.myget.org/F/roundhouse exists), so I assumed some of you guys had it. @ferventcoder, do you have that account?

If not, is there any reason we don't just push to nuget.org?

Member

erikbra commented Nov 13, 2017

I tried to register RoundhousE on MyGet, but it was already taken. (ref https://www.myget.org/F/roundhouse exists), so I assumed some of you guys had it. @ferventcoder, do you have that account?

If not, is there any reason we don't just push to nuget.org?

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

Looks like I own it. What is your account id?

Member

ferventcoder commented Nov 13, 2017

Looks like I own it. What is your account id?

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Nov 13, 2017

Member

erikbra, as on github.

Member

erikbra commented Nov 13, 2017

erikbra, as on github.

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

Found you. Looks like you have access to it now as well.

Member

ferventcoder commented Nov 13, 2017

Found you. Looks like you have access to it now as well.

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Nov 13, 2017

Member

Lovely, thanks, @ferventcoder. You don't mind if I put the API token encrypter for use with AppVeyor in the source code?

Member

erikbra commented Nov 13, 2017

Lovely, thanks, @ferventcoder. You don't mind if I put the API token encrypter for use with AppVeyor in the source code?

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

I'm not sure what you are asking, do you need the encrypted value for the API token?

Member

ferventcoder commented Nov 13, 2017

I'm not sure what you are asking, do you need the encrypted value for the API token?

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

The encrypted value for the api token is XWER/H0IkJ8JWFm+n3/lr7hHoNFAX/VpRD+AfpZo2EUgQkQKhrMxHa4aYZPogsvY

Member

ferventcoder commented Nov 13, 2017

The encrypted value for the api token is XWER/H0IkJ8JWFm+n3/lr7hHoNFAX/VpRD+AfpZo2EUgQkQKhrMxHa4aYZPogsvY

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Nov 13, 2017

Member

No, I can encrypt it myself with https://ci.appveyor.com/tools/encrypt, it uses a per-AppVeyor-subscription key, I was just asking whether you were OK with med committing it (the encrypted value) to the repo. There shouldn't be any harm in doing so, no one else can decrypt it. I just wanted to double-check with you.

Member

erikbra commented Nov 13, 2017

No, I can encrypt it myself with https://ci.appveyor.com/tools/encrypt, it uses a per-AppVeyor-subscription key, I was just asking whether you were OK with med committing it (the encrypted value) to the repo. There shouldn't be any harm in doing so, no one else can decrypt it. I just wanted to double-check with you.

Show outdated Hide outdated appveyor.yml
@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

@erikbra I believe it is per account, not user. In this case the chucknorris account is where you would need to be encrypting it, so you would be logging in under that github account.

Member

ferventcoder commented Nov 13, 2017

@erikbra I believe it is per account, not user. In this case the chucknorris account is where you would need to be encrypting it, so you would be logging in under that github account.

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

@erikbra if it comes out differently than what I posted here, then you may be under the wrong account.

Member

ferventcoder commented Nov 13, 2017

@erikbra if it comes out differently than what I posted here, then you may be under the wrong account.

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

And yes, once encrypted it can be shared in the appveyor.yml file. That's the purpose of it. 👍

Member

ferventcoder commented Nov 13, 2017

And yes, once encrypted it can be shared in the appveyor.yml file. That's the purpose of it. 👍

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

@erikbra you have a merge issue, you should probably fetch upstream/master (this repo, assuming you have the name set as upstream) then do a rebase to your master. Follow that with a rebase against your branch from your local master. That will get you into the rebase conflict dialog so you can correct that.

Member

ferventcoder commented Nov 13, 2017

@erikbra you have a merge issue, you should probably fetch upstream/master (this repo, assuming you have the name set as upstream) then do a rebase to your master. Follow that with a rebase against your branch from your local master. That will get you into the rebase conflict dialog so you can correct that.

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Nov 13, 2017

Member

Thanks, @ferventcoder, I got a different value, but used the one you gave me. But it's not easy to test. Because on my AppVeyor account, it fails, probably because it decrypts using my key. And the RoundhousE AppVeyor only tries to push on master branch. Should we merge and see if it works?

Member

erikbra commented Nov 13, 2017

Thanks, @ferventcoder, I got a different value, but used the one you gave me. But it's not easy to test. Because on my AppVeyor account, it fails, probably because it decrypts using my key. And the RoundhousE AppVeyor only tries to push on master branch. Should we merge and see if it works?

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

We can't merge until you fix the merge conflicts and repush.

Member

ferventcoder commented Nov 13, 2017

We can't merge until you fix the merge conflicts and repush.

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Nov 13, 2017

Member

Fixed the conflicts. Should we merge to see if it works with the key? Do you want to merge, @ferventcoder ? Or should I go ahead?

Member

erikbra commented Nov 13, 2017

Fixed the conflicts. Should we merge to see if it works with the key? Do you want to merge, @ferventcoder ? Or should I go ahead?

@erikbra erikbra merged commit 6dafb16 into chucknorris:master Nov 13, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Nov 13, 2017

Member

Go ahead

Member

ferventcoder commented Nov 13, 2017

Go ahead

@erikbra

This comment has been minimized.

Show comment
Hide comment
@erikbra

erikbra Nov 13, 2017

Member

Yay, it worked!

Deploying using NuGet provider
Publishing roundhouse.0.8.9-pre.1.nupkg to https://www.myget.org/F/roundhouse/api/v2/package...OK
Publishing roundhouse.lib.0.8.9-pre.1.nupkg to https://www.myget.org/F/roundhouse/api/v2/package...OK
Publishing roundhouse.msbuild.0.8.9-pre.1.nupkg to https://www.myget.org/F/roundhouse/api/v2/package...OK
Total packages published: 3
Build success

Member

erikbra commented Nov 13, 2017

Yay, it worked!

Deploying using NuGet provider
Publishing roundhouse.0.8.9-pre.1.nupkg to https://www.myget.org/F/roundhouse/api/v2/package...OK
Publishing roundhouse.lib.0.8.9-pre.1.nupkg to https://www.myget.org/F/roundhouse/api/v2/package...OK
Publishing roundhouse.msbuild.0.8.9-pre.1.nupkg to https://www.myget.org/F/roundhouse/api/v2/package...OK
Total packages published: 3
Build success

@erikbra erikbra deleted the erikbra:Push-to-MyGet branch Nov 13, 2017

@erikbra erikbra changed the title from {WIP} Add push to MyGet from AppVeyor builds to Add push to MyGet from AppVeyor builds Nov 13, 2017

@BiggerNoise

This comment has been minimized.

Show comment
Hide comment
@BiggerNoise

BiggerNoise Nov 13, 2017

Member

Awesome sauce!

Member

BiggerNoise commented Nov 13, 2017

Awesome sauce!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment