Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker distribution of RoundhousE #362

Merged
merged 3 commits into from Jan 27, 2019

Conversation

Projects
None yet
2 participants
@erikbra
Copy link
Member

erikbra commented Jan 26, 2019

Added Dockerfile, which installs dotnet-roundhouse on a Microsoft 2.2. sdk .net core sdk image.

Fixes #342

erikbra added some commits Jan 26, 2019

@erikbra erikbra changed the title Adds docker distribution of RoundhousE Add docker distribution of RoundhousE Jan 26, 2019

@erikbra

This comment has been minimized.

Copy link
Member Author

erikbra commented Jan 26, 2019

@danrien, would you mind taking a look at this PR? IT uses a Dockerfile very similar to the one you linked to in #342 . I am also thinking of the documentation - do you think you could provide some usage scenarios using the docker image? E.g how it's used in a pipeline, etc, and that it generally makes sense. It would be great if you could.

@erikbra

This comment has been minimized.

Copy link
Member Author

erikbra commented Jan 27, 2019

Fixes #342

@erikbra erikbra merged commit a00e81a into chucknorris:master Jan 27, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@erikbra erikbra deleted the erikbra:342-dockerfile branch Jan 27, 2019

@danrien

This comment has been minimized.

Copy link

danrien commented Jan 27, 2019

Hey @erikbra, sorry I didn't get back to you on this sooner. The only suggestion I would have made would have been to tag the image - https://docs.docker.com/engine/reference/commandline/tag/, and likewise, to pin the version of RoundhousE in the image. Microsoft's images are a good reference to follow IMO:

Dotnet image: https://hub.docker.com/r/microsoft/dotnet/
Source: https://github.com/dotnet/dotnet-docker/blob/master/2.2/sdk/stretch/amd64/Dockerfile

Otherwise, this change is awesome!

@erikbra

This comment has been minimized.

Copy link
Member Author

erikbra commented Jan 27, 2019

Sorry, I merged it a bit early, I didn't expect you to reply so soon, but I was running a release, and thought I might include the merge, when I was already on it.

I'm not sure what you mean by tagging the image. I have tagged it here, if that is what you mean? Or do I misunderstand? https://hub.docker.com/r/dotnetroundhouse/roundhouse/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.