Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add docker distribution of RoundhousE #362
@danrien, would you mind taking a look at this PR? IT uses a Dockerfile very similar to the one you linked to in #342 . I am also thinking of the documentation - do you think you could provide some usage scenarios using the docker image? E.g how it's used in a pipeline, etc, and that it generally makes sense. It would be great if you could.
Jan 27, 2019
Hey @erikbra, sorry I didn't get back to you on this sooner. The only suggestion I would have made would have been to tag the image - https://docs.docker.com/engine/reference/commandline/tag/, and likewise, to pin the version of RoundhousE in the image. Microsoft's images are a good reference to follow IMO:
Otherwise, this change is awesome!
Sorry, I merged it a bit early, I didn't expect you to reply so soon, but I was running a release, and thought I might include the merge, when I was already on it.
I'm not sure what you mean by tagging the image. I have tagged it here, if that is what you mean? Or do I misunderstand? https://hub.docker.com/r/dotnetroundhouse/roundhouse/tags