Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget all the things - no more ILMerge #370

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
1 participant
@erikbra
Copy link
Member

commented Feb 7, 2019

There have been multiple issues with ILMerge-ing the assemblies, both the roundhouse lib and rh.exe. This PR splits up roundhouse.lib in multiple nuget packages, so that the consumers can depend on only the one they need, and not pull inn dependencies to totally different database providers.

It also uses Fody/Costura instead of ILMerge, as ILMerge seems to not keep up with the developments in other nuget packages, they stop working when ILMerge-d because of usage of reflection internally. Fody/Costura embeds the dependencies as Assembly resources (compressed) instead of merging them, and injects code to use the embedded assemblied on assembly loading.

Some rewrites to simplify deploy and dependency management

  • Added scripts for running PostgreSQL integration tests
  • Replaced ILMerge with Costura.Fody
  • Fixed some path problems

Packaging restructuring

  • Changed all RoundhousE database DLLs to be nuget packages of their own.
  • Simplified build scripts

@erikbra erikbra force-pushed the erikbra:nuget-all-the-things branch from 14c1d95 to fa5ae40 Feb 12, 2019

@erikbra erikbra force-pushed the erikbra:nuget-all-the-things branch from 4f02f50 to 7c3ef35 Jun 7, 2019

Some rewrites to simplify deploy and dependency management
* Added scripts for running PostgreSQL integration tests
* Replaced ILMerge with Costura.Fody
* Fixed some path problems

Packaging restructuring
* Changed all RoundhousE database DLLs to be nuget packages of their own.
* Simplified build scripts

@erikbra erikbra force-pushed the erikbra:nuget-all-the-things branch from 0bdae95 to 472efd5 Jun 9, 2019

@erikbra erikbra merged commit 83e393d into chucknorris:master Jun 9, 2019

1 of 2 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.