New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement xml content as value in settings #17

Merged
merged 1 commit into from Dec 2, 2015

Conversation

Projects
None yet
3 participants
@jordanwallwork

jordanwallwork commented Nov 25, 2015

Allows using xml in propertys like:

<project>
    <propery name="regular.usage" value="simple property value" />
    <property name="settings.with.xml">
        <xmlParent>
            <child num="1" />
            <child num="2" />
        </xmlParent>
    </property>
</project>
}
break;
}
}

This comment has been minimized.

@ferventcoder

ferventcoder Nov 30, 2015

Member

So what I'm seeing is that we are treating the entire document as an XML file instead of reading through a text file.

@ferventcoder

ferventcoder Nov 30, 2015

Member

So what I'm seeing is that we are treating the entire document as an XML file instead of reading through a text file.

@jordanwallwork

This comment has been minimized.

Show comment
Hide comment
@jordanwallwork

jordanwallwork Dec 1, 2015

Yeah exactly, and then this gives you the flexibility to use xml as a property value. I know it's possible to do something like:

<property name="settings.with.xml" value="<xmlParent><child num='2' /><child num='2' /></xmlParent>" />

But this quickly become unwieldy for larger values (for my use case, I've got a custom configuration section and need to be able to insert arbitrary xml per environment).

jordanwallwork commented Dec 1, 2015

Yeah exactly, and then this gives you the flexibility to use xml as a property value. I know it's possible to do something like:

<property name="settings.with.xml" value="<xmlParent><child num='2' /><child num='2' /></xmlParent>" />

But this quickly become unwieldy for larger values (for my use case, I've got a custom configuration section and need to be able to insert arbitrary xml per environment).

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder

ferventcoder Dec 1, 2015

Member

@drusellers thoughts? This LGTM.

Member

ferventcoder commented Dec 1, 2015

@drusellers thoughts? This LGTM.

@drusellers

This comment has been minimized.

Show comment
Hide comment
@drusellers
Member

drusellers commented Dec 2, 2015

@ferventcoder I like it

ferventcoder added a commit that referenced this pull request Dec 2, 2015

Merge pull request #17 from jordanwallwork/xmlsettings
Implement xml content as value in settings

@ferventcoder ferventcoder merged commit 55b2e52 into chucknorris:master Dec 2, 2015

@ferventcoder

This comment has been minimized.

Show comment
Hide comment
@ferventcoder
Member

ferventcoder commented Dec 2, 2015

Thanks @jordanwallwork !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment