Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Improvement Similar to biowareessmultiplier but for Genemods #3741

Open
davidfoerster opened this issue Jul 5, 2019 · 4 comments

Comments

@davidfoerster
Copy link

commented Jul 5, 2019

Describe the bug

I'm trying to build a critter war form (see Running Wild) but regular characters experience the same issue: the “biowareessmultiplier” and “genetechcostmultiplier” improvements do nothing when added through the improvements tab.

To Reproduce

Steps to reproduce the behaviour:

  1. Create a new character and move it straight to career mode. (Lose all the creation points and karma in the process.) Add some nuyen (e. g. 1.000.000) for later purchases.
  2. Go to the improvement tab and add the bioware essence cost improvement (e. g. with 90 %) and the genetech cost improvement (e. g. with 80 %).
  3. Buy any gentech with sufficiently high essence cost to not be affected by rounding, e. g. a genetic optimization (for any attribute ). The preview lists regular essence cost (0.3) and discounted nuyen cost (37.600 ¥).
  4. Regular nuyen (47.000 ¥) and essence costs (0.3) are deducted.

Expected behaviour

Discounted nuyen (37.600 ¥) and essence (0.27) cost are deducted. Ideally the discounted costs are displayed in the “shopping” preview.

Sample character file

critter war form that already has steps 1 and 2 done/applied.

Desktop

  • OS: Windows 7 (both native and via Wine v4.11)
  • Version: 5.207.0

DelnarErsike pushed a commit that referenced this issue Jul 8, 2019

Gabriel Rath
Genetech Cost Multiplier Fix
Application Changes:

- Fixed an issue where the GenetechCostMultiplier improvement would not work properly. Part of #3741.
@DelnarErsike

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Genetech Cost Multiplier not working properly was a bug, but biowareessmultiplier is working as intended (sort of). Biowareessmultiplier is based on Biocompatibility, and therefore does not affect Genemods. A new improvement needs to be made that affects Genemods if that is the functionality you are looking for.

@DelnarErsike DelnarErsike added the feature label Jul 8, 2019

@DelnarErsike DelnarErsike changed the title biowareessmultiplier and genetechcostmultiplier do nothing Add Improvement Similar to biowareessmultiplier but for Genemods Jul 8, 2019

@davidfoerster

This comment has been minimized.

Copy link
Author

commented Jul 8, 2019

Thanks for the quick fix!

A new improvement needs to be made that affects Genemods if that is the functionality you are looking for.

Yes, that’s what I want.

@chummer5a chummer5a closed this in c3c0218 Jul 11, 2019

@davidfoerster

This comment has been minimized.

Copy link
Author

commented Jul 17, 2019

@DelnarErsike I tested the gene tech essence multiplier improvement in v5.207.29 and, unfortunately, it appears to have no effect. So I would like to reopen this issue.

@chummer5a chummer5a reopened this Jul 17, 2019

@chummer5a

This comment has been minimized.

Copy link
Owner

commented Jul 26, 2019

Hrm. It's because we explicitly ignore essence modifiers if forcegrade="None" is used. Probably need to replace that with an actual property that stipulates whether we want to ignore improvements as well; from memory, it was built to support ignoring things like cyberlimb customisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.