Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thrown weapons ammunition is always "1" #3861

Open
Lochabar opened this issue Sep 12, 2019 · 1 comment

Comments

@Lochabar
Copy link
Collaborator

commented Sep 12, 2019

Describe the bug
Thrown weapons listed in the Ranged Weapons block are always listed as "1" even if there are more that 1 in the gear block.

To Reproduce
Steps to reproduce the behavior:

  1. Using a character with more than 1 in a particular thrown weapon
  2. Print the character
  3. Scroll down to 'Ranged Weapons'
  4. See the "Ammo" column for all thrown weapons always contains 1
  5. Scroll down to 'Gear'
  6. See the Qty for the thrown weapon is more than 1

Expected behavior
The ammo column for thrown weapons show the quantity of the thrown weapon.

Screenshots
Entries from Gear
gear

Corresponding entries in Thrown Weapons
ranged

Desktop (please complete the following information):

  • OS: Windows 7 Home
  • Version: 5.201.12 [and earlier]

Additional context
The saved XML file has an ammo node under the thrown weapon of "1". The corresponding gear node has qty of the correct value.

@chummer5a

This comment has been minimized.

Copy link
Owner

commented Sep 12, 2019

Hrm. That'd be because as far as the weapon is concerned, it has a clip size of 1 and doesn't know about loose ammo. Kind of a pain to refactor it to work differently for just those. Easiest alternative would be making an 'available ammo' int.

chummer5a added a commit that referenced this issue Sep 12, 2019
…osed as 'availableammo'. Still needs to be added to the character sheets. Linked to #3861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.