Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireless management #633

Closed
maximestlaurent opened this issue Jan 15, 2016 · 18 comments
Closed

Wireless management #633

maximestlaurent opened this issue Jan 15, 2016 · 18 comments

Comments

@maximestlaurent
Copy link

As far as I know, wireless bonuses are not included in any character stats because there is no way to tell whether or not the character currently has access to the Matrix wirelessly. I suggest we take a page out of HeroLab's book and add an "Wireless On/Off" switch that adds and removes the wireless bonuses from different items on the character sheet.

@McRipolo
Copy link

Good idea, maybe show two Dice Pools one normal and one "Wifi on" Pool

@maximestlaurent
Copy link
Author

I'd have to double check, but I believe the bonuses are not always Dice Pool related. Thus, I was thinking more along the line of simply adding and removing the bonuses where applicable based on whether the toggle is On or Off.

Something different would have to be done for a printed charcter sheet, though.

@chummer5a
Copy link
Owner

Yeah, I've been pondering how to handle this for a while now. It's somewhere at the back of the queue, behind the skill rewrite but ahead of shapeshifters.

@maximestlaurent
Copy link
Author

Are the Wireless bonuses in the data? I can't seem to find them.

@chummer5a
Copy link
Owner

Nope; I'll have to build in functionality for it, probably something along
the lines of a flag that only enables it if it's present or
something.

On 18 January 2016 at 11:25, Maxime St-Laurent notifications@github.com
wrote:

Are the Wireless bonuses in the data? I can't seem to find them.


Reply to this email directly or view it on GitHub
#633 (comment)
.

@maximestlaurent
Copy link
Author

If you need any help, I can contribute.

@chummer5a
Copy link
Owner

Will do; generally with this sort of thing I mock up enough to be reasonably sure the concept will work and then farm out the data-entry, so I'll update this when the time comes for that.

@chummer5a
Copy link
Owner

The backing code for wireless bonuses has been implemented. Additional required changes:

  • Method for toggling Wireless in the UI
  • Data entry for all items that have a wireless bonus with a mechanical effect

@maximestlaurent
Copy link
Author

maximestlaurent commented Jul 13, 2018

I've picked up again Shadowrun recently, and see this issue is close to being done. As I commented before, I can help resolve this, so I'll get started on the data entry in the near future.

@maximestlaurent
Copy link
Author

@chummer5a Has something been done for printed character sheets relating to this feature? I'm curious to see how we could display the Wireless bonuses in printed form.

@chummer5a
Copy link
Owner

Honestly it's sort of a field of dreams situation; nothing's been done on the presentation layer because there's been nothing to show. The main problem is how to represent things like the Wired Reflexes/Reflex Booster combo, but we could probably safely proxy that with a user-writable Wireless Notes field.

@maximestlaurent
Copy link
Author

I've just re-read the "Wireless" rule in Shadowrun 5, and there's something we didn't take into account: wireless can be blocked by noise. If the "effective" noise rating (once noise reduction has been taken into account) is higher than a device's rating, its wireless gets disabled. This means we can't simply have a "Wireless: OFF/ON" switch in the UI.

Do we want to have a "Wireless management" tab/widget which can take noise into account?

@chummer5a
Copy link
Owner

The idea I had was for the wireless toggle to be 'I want this to be on'. It would still have an enabled-disabled state based on the Noise and Noise Reduction available to the object, but given the occasional quirks with noise reduction, a separate panel might be necessary.

@maximestlaurent
Copy link
Author

Is there a way to specify current noise in Chummer5a? I can't seem to find anything.

@chummer5a
Copy link
Owner

Currently no; it'd just be a pointless spinner with the current codebase.

@maximestlaurent
Copy link
Author

I'm guessing a "Noise" panel would be good, as you suggested. It could simply be two spinners (noise, noise reduction) and an "effective noise", which would be used to enable/disable the wireless bonuses.

If the data for noise reduction is in the codebase, we might be able to calculate the player's noise reduction.

@chummer5a
Copy link
Owner

The main requirement for this has been implemented by 2491b81. Noise hasn't been done yet.

@stale
Copy link

stale bot commented Jun 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 26, 2020
@stale stale bot closed this as completed Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants