Fix UART console on FreeBSD 12.1 and CURRENT. #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhyve was doing UART console emulation on fd 0 for both reads and writes. Commits r346550 and r352720 changed it to use fd 0 for input and fd 1 for output on console. Fix vm-bhyve to not redirect fd 1. Fixes churchers#332.
dch
approved these changes
Nov 27, 2019
|
lgtm! |
|
Works for me under 12.1-RELEASE-p1 |
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for issue #332 turns out to be simple. Tested on 11.3 and 12.1.