Rubocop autocorrect for authorizers

app/authorizers/album_authorizer.rb

@@ -43,7 +43,7 @@ def updatable_by?(user)
     end
   end
 
-  alias_method :deletable_by?, :updatable_by?
+  alias deletable_by? updatable_by?
 
   def self.readable_by(user, scope = Album.all)
     if user.admin?(:manage_pictures)
@@ -52,7 +52,7 @@ def self.readable_by(user, scope = Album.all)
       scope.where(
         "(owner_type = 'Person' and owner_id in (?)) or " \
         "(owner_type = 'Group' and owner_id in (?)) or " \
-        "is_public = ?",
+        'is_public = ?',
         [user.id] + user.friend_ids,
         user.group_ids,
         true

app/authorizers/application_authorizer.rb

@@ -1,7 +1,5 @@
 class ApplicationAuthorizer < Authority::Authorizer
-
-  def self.default(adjective, user)
+  def self.default(_adjective, _user)
     false
   end
-
 end

app/authorizers/attachment_authorizer.rb

@@ -1,9 +1,7 @@
 class AttachmentAuthorizer < ApplicationAuthorizer
   def readable_by?(user)
     # on a message I can see
-    if resource.message and user.can_read?(resource.message)
-      true
-    end
+    true if resource.message && user.can_read?(resource.message)
   end
 
   def deletable_by?(user)

app/authorizers/comment_authorizer.rb

@@ -1,6 +1,5 @@
 class CommentAuthorizer < ApplicationAuthorizer
-
-  def readable_by?(user)
+  def readable_by?(_user)
     false # TODO
   end
 
@@ -14,6 +13,5 @@ def updatable_by?(user)
     end
   end
 
-  alias_method :deletable_by?, :updatable_by?
-
+  alias deletable_by? updatable_by?
 end

app/authorizers/family_authorizer.rb

@@ -1,28 +1,27 @@
 class FamilyAuthorizer < ApplicationAuthorizer
-
   def self.creatable_by?(user)
     user.admin?(:edit_profiles)
   end
 
   def readable_by?(user)
     # my family
-    if resource == user.family and not resource.deleted?
+    if resource == user.family && !resource.deleted?
       true
     # visible to everyone
-    elsif resource.visible? and not resource.deleted?
+    elsif resource.visible? && !resource.deleted?
       true
     # visible and deleted
-    elsif resource.visible? and resource.deleted?
+    elsif resource.visible? && resource.deleted?
       true if user.admin?(:edit_profiles)
     # invisible and deleted
-    elsif not resource.visible? and resource.deleted?
-      true if user.admin?(:edit_profiles) and user.admin?(:view_hidden_profiles)
+    elsif !resource.visible? && resource.deleted?
+      true if user.admin?(:edit_profiles) && user.admin?(:view_hidden_profiles)
     end
   end
 
   def updatable_by?(user)
     # my family
-    if resource == user.family and user.adult? and not resource.deleted? and not user.account_frozen?
+    if resource == user.family && user.adult? && !resource.deleted? && !user.account_frozen?
       true
     # admins with edit_profiles privilege
     elsif user.admin?(:edit_profiles)
@@ -52,5 +51,4 @@ def deletable_by?(user)
   def reorderable_by?(user)
     user.admin?(:edit_profiles)
   end
-
 end

app/authorizers/group_authorizer.rb

@@ -1,8 +1,7 @@
 class GroupAuthorizer < ApplicationAuthorizer
-
   def readable_by?(user)
     # pubic, visible-to-everyone group
-    if not (resource.hidden? or resource.private?)
+    if !(resource.hidden? || resource.private?)
       true
     # user is a member of the group
     elsif user.member_of?(resource)
@@ -15,14 +14,13 @@ def readable_by?(user)
 
   def updatable_by?(user)
     # user is an admin of the group
-    if user.member_of?(resource) and resource.admin?(user)
+    if user.member_of?(resource) && resource.admin?(user)
       true
     # user is global admin with manage_groups privilege
     elsif user.admin?(:manage_groups)
       true
     end
   end
 
-  alias_method :deletable_by?, :updatable_by?
-
+  alias deletable_by? updatable_by?
 end

app/authorizers/membership_authorizer.rb

@@ -1,13 +1,12 @@
 class MembershipAuthorizer < ApplicationAuthorizer
-
-  def readable_by?(user)
+  def readable_by?(_user)
     false # TODO
   end
 
   def creatable_by?(user)
     if user.can_update?(resource.group)
       true
-    elsif resource.group and not resource.group.approval_required_to_join?
+    elsif resource.group && !resource.group.approval_required_to_join?
       true
     end
   end
@@ -17,7 +16,7 @@ def updatable_by?(user)
     if resource.person == user
       true
     # someone in my family and I'm an adult
-    elsif resource.person.try(:family) == user.family and user.adult?
+    elsif resource.person.try(:family) == user.family && user.adult?
       true
     # group admin
     elsif resource.group.try(:admin?, user)
@@ -28,6 +27,5 @@ def updatable_by?(user)
     end
   end
 
-  alias_method :deletable_by?, :updatable_by?
-
+  alias deletable_by? updatable_by?
 end

app/authorizers/message_authorizer.rb

@@ -1,26 +1,25 @@
 class MessageAuthorizer < ApplicationAuthorizer
-
   def readable_by?(user)
     # message is from me
-    if resource.person and resource.person == user
+    if resource.person && resource.person == user
       true
     # message is to me
-    elsif resource.to and resource.to == user
+    elsif resource.to && resource.to == user
       true
     # message in a group I'm a member of
-    elsif resource.group and user.member_of?(resource.group)
+    elsif resource.group && user.member_of?(resource.group)
       true
     end
   end
 
   def creatable_by?(user)
     # first make sure a reply isn't on a message I can't see
-    return false if resource.parent and not user.can_read?(resource.parent)
+    return false if resource.parent && !user.can_read?(resource.parent)
     # message in a group and I'm a member or admin
-    if resource.group and resource.group.can_send?(user)
+    if resource.group && resource.group.can_send?(user)
       true
     # message to a person and I can see that person and they have messaging enabled
-    elsif resource.to and user.can_read?(resource.to) and resource.to.messages_enabled?
+    elsif resource.to && user.can_read?(resource.to) && resource.to.messages_enabled?
       true
     end
   end
@@ -35,7 +34,7 @@ def updatable_by?(user)
     end
   end
 
-  alias_method :deletable_by?, :updatable_by?
+  alias deletable_by? updatable_by?
 
   def self.readable_by(user, scope = Message.all)
     if user.admin?(:manage_pictures)
@@ -44,12 +43,11 @@ def self.readable_by(user, scope = Message.all)
       scope.where(
         "(owner_type = 'Person' and owner_id in (?)) or " \
         "(owner_type = 'Group' and owner_id in (?)) or " \
-        "is_public = ?",
+        'is_public = ?',
         [user.id] + user.friend_ids,
         user.group_ids,
         true
       )
     end
   end
-
 end

app/authorizers/news_item_authorizer.rb

@@ -1,6 +1,5 @@
 class NewsItemAuthorizer < ApplicationAuthorizer
-
-  def readable_by?(user)
+  def readable_by?(_user)
     true
   end
 
@@ -14,6 +13,5 @@ def updatable_by?(user)
     end
   end
 
-  alias_method :deletable_by?, :updatable_by?
-
+  alias deletable_by? updatable_by?
 end

app/authorizers/page_authorizer.rb

@@ -1,13 +1,11 @@
 class PageAuthorizer < ApplicationAuthorizer
-
-  def readable_by?(user)
+  def readable_by?(_user)
     false # TODO
   end
 
   def updatable_by?(user)
     user.admin?(:edit_pages)
   end
 
-  alias_method :deletable_by?, :updatable_by?
-
+  alias deletable_by? updatable_by?
 end

app/authorizers/person_authorizer.rb

@@ -1,18 +1,17 @@
 class PersonAuthorizer < ApplicationAuthorizer
-
   def self.creatable_by?(user)
     user.admin?(:edit_profiles)
   end
 
   def readable_by?(user)
     # myself
-    if resource == user and not deleted?
+    if resource == user && !deleted?
       true
     # my family and I'm a parent (adult)
-    elsif resource.family and resource.family == user.family and user.adult? and not deleted?
+    elsif resource.family && resource.family == user.family && user.adult? && !deleted?
       true
     # visible to everyone
-    elsif visible? and not deleted?
+    elsif visible? && !deleted?
       true
     # admins with this privilege can view all
     elsif user.admin?(:view_hidden_profiles)
@@ -22,10 +21,10 @@ def readable_by?(user)
 
   def updatable_by?(user)
     # myself
-    if resource == user and not deleted? and not resource.account_frozen?
+    if resource == user && !deleted? && !resource.account_frozen?
       true
     # my family and I'm a parent (adult)
-    elsif resource.family and resource.family == user.family and user.adult? and not deleted? and not resource.account_frozen?
+    elsif resource.family && resource.family == user.family && user.adult? && !deleted? && !resource.account_frozen?
       true
     # admins with edit_profiles privilege
     elsif user.admin?(:edit_profiles)
@@ -41,20 +40,19 @@ def updatable_by?(user)
 
   def deletable_by?(user)
     # admins with edit_profiles privilege
-    if visible? and user.admin?(:edit_profiles)
+    if visible? && user.admin?(:edit_profiles)
       true
     # admins with these privileges can see and edit all
-    elsif user.admin?(:view_hidden_profiles) and user.admin?(:edit_profiles)
+    elsif user.admin?(:view_hidden_profiles) && user.admin?(:edit_profiles)
       true
     end
   end
 
   def deleted?
-    resource.deleted? or resource.family.try(:deleted?)
+    resource.deleted? || resource.family.try(:deleted?)
   end
 
   def visible?
     resource.visible?
   end
-
 end

app/authorizers/picture_authorizer.rb

@@ -1,23 +1,21 @@
 class PictureAuthorizer < ApplicationAuthorizer
-
   def readable_by?(user)
     resource.album.readable_by?(user)
   end
 
   def creatable_by?(user)
-    resource.person == user or
-    (resource.album and resource.album.creatable_by?(user))
+    resource.person == user ||
+      (resource.album && resource.album.creatable_by?(user))
   end
 
   def updatable_by?(user)
-    resource.person == user or
-    resource.album.updatable_by?(user)
+    resource.person == user ||
+      resource.album.updatable_by?(user)
   end
 
-  alias_method :deletable_by?, :updatable_by?
-  alias_method :rotatable_by?, :updatable_by?
+  alias deletable_by? updatable_by?
+  alias rotatable_by? updatable_by?
 
-  def self.readable_by(user, scope = Picture.all)
+  def self.readable_by(_user, _scope = Picture.all)
   end
-
 end

app/authorizers/prayer_request_authorizer.rb

@@ -1,15 +1,14 @@
 class PrayerRequestAuthorizer < ApplicationAuthorizer
-
   def readable_by?(user)
     if resource.person == user
       true
-    elsif resource.group and user.member_of?(resource.group)
+    elsif resource.group && user.member_of?(resource.group)
       true
     end
   end
 
   def creatable_by?(user)
-    if resource.group and user.member_of?(resource.group) and resource.group.prayer?
+    if resource.group && user.member_of?(resource.group) && resource.group.prayer?
       true
     end
   end
@@ -24,7 +23,7 @@ def updatable_by?(user)
     end
   end
 
-  alias_method :deletable_by?, :updatable_by?
+  alias deletable_by? updatable_by?
 
   def self.readable_for_group_by_user(group, user)
     if user.member_of?(group)

app/authorizers/task_authorizer.rb

@@ -1,15 +1,14 @@
 class TaskAuthorizer < ApplicationAuthorizer
-
   def readable_by?(user)
     if resource.person == user
       true
-    elsif resource.group and user.member_of?(resource.group)
+    elsif resource.group && user.member_of?(resource.group)
       true
     end
   end
 
   def creatable_by?(user)
-    if resource.group and user.member_of?(resource.group) and resource.group.has_tasks?
+    if resource.group && user.member_of?(resource.group) && resource.group.has_tasks?
       true
     end
   end
@@ -23,7 +22,7 @@ def updatable_by?(user)
     end
   end
 
-  alias_method :deletable_by?, :updatable_by?
+  alias deletable_by? updatable_by?
 
   def self.readable_for_group_by_user(group, user)
     if user.member_of?(group)