Skip to content

Move business logic out of controllers. #40

seven1m opened this Issue Jul 1, 2013 · 1 comment

1 participant

Church.IO member
seven1m commented Jul 1, 2013

Lots of our controllers (and views, but we'll get to those later) contain business logic. A big task will be to move that to models and concerns.

This is related to #48, moving authorization logic into Authorizer classes.

I intend to tackle these controller-by-controller:

  • AccountsController
  • AlbumsController
  • AttachmentsController
  • AttendanceController
  • CommentsController
  • FamiliesController
  • FeedsController
  • GroupsController
  • MembershipsController
  • MessagesController
  • NewsController
  • NotesController
  • PeopleController
  • PhotosController
  • PicturesController
  • PrivaciesController
  • RelationshipsController
  • SearchesController
  • SessionsController
  • SetupsController
  • VersesController
  • Administration::AdminsController
  • Administration::AttendanceController
  • Administration::DashboardsController
  • Administration::SettingsController
  • Administration::UpdatesController
Church.IO member
seven1m commented Mar 28, 2014

I'm going to close this ticket for now. Tackling all this in a single go isn't reasonable :(

I will instead open a few tickets to refactor the most offensive controllers.

@seven1m seven1m closed this Mar 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.