New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent too deep recursion #109

Merged
merged 2 commits into from Sep 15, 2018

Conversation

Projects
None yet
3 participants
@xfix
Copy link
Contributor

xfix commented Sep 15, 2018

No description provided.

@xfix xfix referenced this pull request Sep 15, 2018

Merged

Prevent too deep recursion #105

@dtolnay
Copy link
Collaborator

dtolnay left a comment

Thanks!

@dtolnay dtolnay force-pushed the xfix:prevent-too-deep-recursion branch from 644ee83 to 35ca228 Sep 15, 2018

@dtolnay dtolnay merged commit 7eb6b6a into chyh1990:master Sep 15, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@Shnatsel

This comment has been minimized.

Copy link

Shnatsel commented Jan 5, 2019

Is it possible to backport this to 0.3.x series? According to crates.io stats, half of the recent downloads of rust-yaml are in the 0.3.x.

If this fix is already backported, please let me know and I'll update the security advisory.

@xfix

This comment has been minimized.

Copy link
Contributor Author

xfix commented Jan 6, 2019

@Shnatsel Most of the rust-yaml downloads are due to clap, which isn't really affected by this issue, making this mostly unimportant.

@Shnatsel

This comment has been minimized.

Copy link

Shnatsel commented Jan 6, 2019

There is a total of 165 crates on crates.io currently affected without a semver-compatible upgrade path, according to crates-audit. So it might not be as unimportant as it seems.

@Shnatsel

This comment has been minimized.

Copy link

Shnatsel commented Jan 6, 2019

Here's the list of affected crates, without crates depending on clap, sorted by recent download count: https://ncry.pt/p/vzOn#8UqV4ktfnn67-ReSMfvj-xjFZQq1wdDh3uUzK8AhxBk
That's 51 crates, nothing really critical at the top of the list as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment