New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on images/video sometimes opens up on external browser #250

Open
scarfa opened this Issue Jan 10, 2019 · 6 comments

Comments

2 participants
@scarfa
Copy link

scarfa commented Jan 10, 2019

When I click on an embedded video it's very inconsistent, sometimes it'll open within TweetDuck and other times it'll open the tweet with the video in an external browser like Chrome. When it does open in an external browser, there's dark semi-transparent overlay that covers TweetDuck that won't go away and I can't click on anything or interact with the app anymore unless I reload TweetDuck.

Picture of the overlay that covers everything here. I believe this overlay is used to darken the background when a image/video is opened within TweetDuck but seems to be incorrectly used when the tweet is redirected to an external browser.

Using release 1.17.2

@chylex

This comment has been minimized.

Copy link
Owner

chylex commented Jan 10, 2019

I wonder if it's related to #249, both issues seem to be related to media getting inconsistently broken.

@scarfa

This comment has been minimized.

Copy link

scarfa commented Jan 10, 2019

I don't know if they are related but it seems to me to be separate issues, although the bug you mentioned has also happened to me. Having used this app extensively these are the big issues I've encountered:

  1. YouTube videos shows a message saying it can't play within the TweetDuck modal dialog but must be played in an external browser.

  2. Some Tweets cannot be opened which is #249

  3. Tweets with videos(Twitter video and YouTube) sometimes not opening in TweetDuck but automatically opening in an external browser. An overlay then covers the app that can't be removed. This is my problem.

I wonder if you can just remove the overlay as a temporary fix until you figure something better? That would certainly fix part of my issue. Right now I'm forced to re-open TweetDuck whenever it happens and lose my place in the timeline.

@chylex

This comment has been minimized.

Copy link
Owner

chylex commented Jan 11, 2019

If the overlay appears, then the app was instructed to start the video player which removes the overlay on its own when it exits. If that doesn't happen and you can't see the video, I'd guess the entire app is frozen. When it happens again, check the task manager for TweetDuck.Video.exe, and see if you can right-click anywhere in the app (if you can, try opening Options to see if it responds).

@scarfa

This comment has been minimized.

Copy link

scarfa commented Jan 11, 2019

The app doesn't seem to be frozen b/c the timelines are still moving with new tweets. Looks like it's working as normal but the overlay is just preventing me from clicking on anything inside the TweetDuck window. I can right click though as you suggested and it shows "Reload browser", "Mute notifications", "Options", "Plugins", "About TweetDuck".

@chylex

This comment has been minimized.

Copy link
Owner

chylex commented Jan 12, 2019

Does opening Options work? The browser part is mostly independent of the main app, it might work in the background while the app is frozen. You could try opening (install dir)/scripts/code.js and deleting lines 858-860 that add the overlay, but you'll have to close videos through the player instead.

$('<div id="td-video-player-overlay" class="ovl" style="display:block"></div>').on("click contextmenu", function(){
$TD.playVideo(null, null);
}).appendTo(app);

Either way, I need a way to reproduce the issue on my system, and so far I haven't been able to do that with either this or #249.

@scarfa

This comment has been minimized.

Copy link

scarfa commented Jan 13, 2019

Thank you, the fix is very hacky but works, if only as a temporary solution. Some observations I made that may help you in regards to bug #249 and seems to tie into my problem.

  1. Tweets with video that can be expanded when clicked, when the video is clicked it opens fine inside the app.
  2. Tweets with video that can't be expanded when clicked(bug #249), when the video is clicked the tweet opens in an external browser instead and leaves the overlay in the app that doesn't go away.
  3. Tweets with images that can't be expanded when clicked(bug #249), the images open fine inside the app.
  4. Tweets with video's are more likely to exhibit bug #249 than ones with images.
  5. Columns made with 'content matching' using a hashtag or normal keyword seems to exhibit bug #249 . Incidentally some of these columns, I can't open the column options menu either. If I re-open TweetDuck the column options menu works again.
  6. Columns made with custom lists filled with handpicked Twitter users does NOT exhibit bug #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment