Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Can't delete Editor role #755

Closed
artlantis opened this Issue Mar 21, 2013 · 2 comments

Comments

Projects
None yet
2 participants

As specified ( Removable ), we may delete this role from the system. But, when we tried, bonfire doesn't delete the role without show any error message, please check!

Contributor

sourcejedi commented Mar 21, 2013

Correct. This is covered by #699. I'll email the other devs about making a decision on merging it. (And if not, then we can start hacking around it again).

@sourcejedi sourcejedi added a commit that referenced this issue Mar 22, 2013

@sourcejedi sourcejedi Revert to use of isset($_POST[]) for submit buttons
Fix the unfortunately incomplete revert of post_key_exists().
See #699 for the known issues, mainly nonfunctional delete `<button>`s.
Also reported as #755.

post_key_exists() was intended to replace, unify and name the necessary
usage of isset($_POST[]).  This attempt drops the replace and name part :).

I assumed post_key_exists() was already in the right places, and ran a
global search+replace on it.

git checkout -b tmp
git revert be42cff
git diff -w > revert.patch
git checkout develop
git branch -D tmp

patch -p1 < revert.patch #+1 fix of rejected hunk

git rm application/core/MY_Input.php

find -name *.php -exec sed -e "s/\\\\\$this->input->post_key_exists('\([^']*\)')/isset(\\\\\$_POST['\1'])/g" -i \{\} \;

find -name *.php -exec sed -e "s/\$this->input->post_key_exists('\([^']*\)')/isset(\$_POST['\1'])/g" -i \{\} \;

git grep post_key_exists
2708157
Contributor

sourcejedi commented Mar 22, 2013

Ok, it should work now.

Instead of the new api in #699, I've effectively inlined the code. It doesn't seem that bad, there's just the matter of documenting it somehow...

@sourcejedi sourcejedi closed this Mar 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment