Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Migration version is always up when run SQL migrations fails. #757

Closed
minkbear opened this Issue · 1 comment

2 participants

@minkbear

I looked into the code and met that $schema_version is always up but it doesn't case the result of execute sql migration when it's fail.

@sourcejedi sourcejedi was assigned
@sourcejedi sourcejedi referenced this issue from a commit
@sourcejedi sourcejedi migrations controller migrate_to: fix one error message
Don't overwrite the error message if migrations fail!

The error case is probably still broken generally, see #757, but this part
is an obvious coding error.
cbbbedc
@mwhitneysdsu mwhitneysdsu closed this issue from a commit
@mwhitneysdsu mwhitneysdsu Fix #757 and other Migrations updates
- Re-arranged changelog slightly, see the Migrations section under
"Additional Changes" for a more detailed listing of the changes to the
Migrations module.
- Fix #757: version is always up when SQL migrations fail
- Fixed an error in the library's version() method when an error
occurred in glob() while retrieving the migrations for a given step
- Made numerous changes to reduce the number of database hits,
especially when auto-migrating, when a large number of modules are
installed, or when migrating multiple versions at once.
- Overhauled the library's API, deprecated most of the existing public
methods/properties (all public methods/properties still work, but may
not perform quite as well, since the methods are forwarding requests to
the new methods) - I intend to update any other uses of the library in
Bonfire's code to make sure the deprecated methods are not used
elsewhere.
6401266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.