ModuleBuilder fixes #483

Merged
merged 2 commits into from Jun 9, 2012

Conversation

Projects
None yet
3 participants
Member

mwhitneysdsu commented Jun 8, 2012

  • view_default: remove / before site_url in delete button
  • view_index: fix colspan on table footer when using soft deletes,
    created, or modified fields
ModuleBuilder fixes
- db migration: add prefix to table name in create_table and drop_table
statements
- view_default: remove / before site_url in delete button
- view_index: fix colspan on table footer when using soft deletes,
created, or modified fields
Owner

lonnieezell commented Jun 8, 2012

I haven't looked at the rest of it, yet, but you don't need to manually add the prefix within dbforge calls. Just like the db functions, it will use the database config's db_prefix value and append it to it.

Member

mwhitneysdsu commented Jun 9, 2012

I've removed the create/drop table changes. The rest should be fairly straight-forward, the view_default file was generating an href like /http://..., and the view_index file is most obvious when using all three fields (soft delete, created, and modified), since the table footer is 2 columns short of the full table width.

seandowney added a commit that referenced this pull request Jun 9, 2012

@seandowney seandowney merged commit 420781b into ci-bonfire:develop Jun 9, 2012

Owner

seandowney commented Jun 9, 2012

Thanks @mwhitneysdsu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment