Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Better rspec 2.0 support #31

Merged
merged 4 commits into from Jun 14, 2011

Conversation

Projects
None yet
2 participants
Contributor

heathkit commented Jun 13, 2011

Here are some tweaks I made to provide slightly better RSpec 2.0 integration in my project. I can break these out into separate pulls if you like. This fixes:

  1. Formatting of the documentation output when using the documation formatter with ci_reporter. 'example_group_finished' wasn't being called, so it never reduced the indentation level
  2. 'dump_failures' wasn't being called, so when using the ci_reporter it wouldn't dump out failures the way it normally does
  3. Stack traces weren't being formatted the rspec usually does it. RSpec will show a simplified stacktrace depicting only your test, unless you explicitly pass an option enabling full stack traces. The abbreviated stack traces are now what end up in the junit output, unless you specify you want the full dump.

@nicksieger nicksieger added a commit that referenced this pull request Jun 14, 2011

@nicksieger nicksieger Merge pull request #31 from mgiambalvo/master
Better rspec 2.0 support
867a5b3

@nicksieger nicksieger merged commit 867a5b3 into ci-reporter:master Jun 14, 2011

Owner

nicksieger commented Jun 14, 2011

Looks great. Thanks for contributing back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment