Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

The reverted code will produce nil exceptions with rspec 1.3.1 and ci_reporter 1.7.0 #53

Merged
merged 1 commit into from

2 participants

Christian van der Leeden Nick Sieger
Christian van der Leeden

...rter/commit/f700e0522c8f18182737a798aa4b357e4453a405#diff-0)"

This reverts commit eca73f1.

Looking at the code and running it in the debugger, there is no instance variable named "@example", I've reverted the old commit. With this it works fine on jenkins with our setup with rspec 1.3.1.

Christian van der Leeden next2you Revert "RSpec 2.2.1 compatability (crossroads/ci_reporter@f700e05#diff-0
)"

This reverts commit eca73f1375d68a20bb3e2d5741fe9820332b0538.
48d7389
Nick Sieger nicksieger merged commit 9a68db5 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 21, 2012
  1. Christian van der Leeden

    Revert "RSpec 2.2.1 compatability (crossroads/ci_reporter@f700e05#diff-0

    next2you authored
    )"
    
    This reverts commit eca73f1375d68a20bb3e2d5741fe9820332b0538.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +3 −3 lib/ci/reporter/rspec.rb
6 lib/ci/reporter/rspec.rb
View
@@ -43,9 +43,9 @@ def error?
!failure?
end
- def name() @example.metadata[:execution_result][:exception].class.name end
- def message() @example.metadata[:execution_result][:exception].message end
- def location() @example.metadata[:execution_result][:exception].backtrace.join("\n") end
+ def name() exception.class.name end
+ def message() exception.message end
+ def location() (exception.backtrace || ["No backtrace available"]).join("\n") end
end
class RSpec2Failure < RSpecFailure
Something went wrong with that request. Please try again.