Fixed failing spec plus fixed bug when calling system commands through back-ticks #56

Merged
merged 2 commits into from Nov 30, 2012

Conversation

Projects
None yet
3 participants
@orlanthi

Hi Nick,

I've just committed a couple of changes to my fork - one to fix a failing spec and one to fix a bug when back-ticked commands are called as part of a test. The commit messages should be fairly self-explanatory.

It would be nice if the output of a back-ticked command was also captured in the xml but I don't know how to make that happen (I tried creating a test case to look at the test suite output but nothing came through).

Regards,

Brendan

Brendan Boesen added some commits Apr 26, 2012

Brendan Boesen
Fixed failing spec.
The spec was failing because it relied on a hard-coded expectation of the shortened file path and the actual path depends on where you have the project checked-out.
Brendan Boesen
Fixed bug where back-tick system calls where failing.
When making a system call using back-ticks, eg: /Users/brendanboesen/Documents/projects/ci_reporter, the call was failing because  was set to nil.
This turned out to be a bug in the initialization of the Delegate where the delegate instance (currently nil) was passed to the 'assign' block instead of the captured IO stream.
@cheald

This comment has been minimized.

Show comment Hide comment
@cheald

cheald May 14, 2012

+1

cheald commented May 14, 2012

+1

@nicksieger nicksieger merged commit 9dfda81 into ci-reporter:master Nov 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment