Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

make sure @suite is not nil before using it. This happens when the before(:suite) fails. #68

Merged
merged 1 commit into from Sep 10, 2012

Conversation

Projects
None yet
3 participants

We had an issue with our RSpec config.before(:suite) block. Was
getting:

NoMethodError: undefined method `finish' for nil:NilClass
write_report at …/ci_reporter-1.7.0/lib/ci/reporter/rspec.rb:202

make sure @suite is not nil
We had an issue with our RSpec config.before(:suite) block.  Was
getting:

NoMethodError: undefined method `finish' for nil:NilClass
  write_report at …/ci_reporter-1.7.0/lib/ci/reporter/rspec.rb:202

+1 for me : When there is no spec suite to run, it fails

nicksieger added a commit that referenced this pull request Sep 10, 2012

Merge pull request #68 from patcheng/master
make sure @suite is not nil before using it. This happens when the before(:suite) fails.

@nicksieger nicksieger merged commit 63ea29a into ci-reporter:master Sep 10, 2012

Owner

nicksieger commented Sep 10, 2012

Thanks for the patch and for reviving it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment