LoadError for rspec/version for apps that use rspec-rails #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DFrenkel
commented
Dec 4, 2012
DFrenkel
commented
- Fix for ci_reporter-1.8.2/lib/ci/reporter/rspec.rb:19:in `require': no such file to load -- rspec/version (LoadError) when using rspec-rails. Instead of using 'rspec/version', we should be using 'rspec/core/version'. For apps that use vanilla rspec, that also exists and will work just fine. However, for apps that use rspec-rails, rspec/version does not exist. It is probably a mistake by rspec to have version.rb in both rspec and in rspec-core as it introduces unnecessary confusion that causes this issue.
- Fix for ci_reporter-1.8.2/lib/ci/reporter/rspec.rb:19:in `require': no such file to load -- rspec/version (LoadError) when using rspec-rails. Instead of using 'rspec/version', we should be using 'rspec/core/version'. For apps that use vanilla rspec, that also exists and will work just fine. However, for apps that use rspec-rails, rspec/version does not exist. It is probably a mistake by rspec to have version.rb in both rspec and in rspec-core as it introduces unnecessary confusion that causes this issue.
nicksieger
added a commit
that referenced
this pull request
Dec 5, 2012
LoadError for rspec/version for apps that use rspec-rails
|
Thanks! |
|
Glad to help! |
|
Would it be possible to release this? Unless I'm missing something (very possible) it didn't make it into 1.8.3 (https://github.com/nicksieger/ci_reporter/blob/f59cbf16cd6f908964abebce2e5f81bd35d60fc8/lib/ci/reporter/rspec.rb) so we're still seeing this. Thanks for any help! |
|
same here, 1.8.3 did not fix the problem |
|
Sorry guys! 1.8.4 is released now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.