LoadError for rspec/version for apps that use rspec-rails #83

Merged
merged 1 commit into from Dec 5, 2012

4 participants

@DFrenkel
  • Fix for ci_reporter-1.8.2/lib/ci/reporter/rspec.rb:19:in `require': no such file to load -- rspec/version (LoadError) when using rspec-rails. Instead of using 'rspec/version', we should be using 'rspec/core/version'. For apps that use vanilla rspec, that also exists and will work just fine. However, for apps that use rspec-rails, rspec/version does not exist. It is probably a mistake by rspec to have version.rb in both rspec and in rspec-core as it introduces unnecessary confusion that causes this issue.
@DFrenkel DFrenkel Fixing LoadError for rspec/version for apps that use rspec-rails
- Fix for ci_reporter-1.8.2/lib/ci/reporter/rspec.rb:19:in `require': no such file to load -- rspec/version (LoadError) when using rspec-rails. Instead of using 'rspec/version', we should be using 'rspec/core/version'. For apps that use vanilla rspec, that also exists and will work just fine. However, for apps that use rspec-rails, rspec/version does not exist. It is probably a mistake by rspec to have version.rb in both rspec and in rspec-core as it introduces unnecessary confusion that causes this issue.
342748c
@nicksieger nicksieger merged commit 021bbb9 into ci-reporter:master Dec 5, 2012
@nicksieger
ci-reporter member

Thanks!

@DFrenkel

Glad to help!

@mrooney

Would it be possible to release this? Unless I'm missing something (very possible) it didn't make it into 1.8.3 (https://github.com/nicksieger/ci_reporter/blob/f59cbf16cd6f908964abebce2e5f81bd35d60fc8/lib/ci/reporter/rspec.rb) so we're still seeing this. Thanks for any help!

@tchak

same here, 1.8.3 did not fix the problem

@nicksieger
ci-reporter member

Sorry guys! 1.8.4 is released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment