Cian Clarke cianclarke

Organizations

@feedhenry
@cianclarke
@cianclarke
Posting a V1 `ProjectRequest` drops Labels and Annotations
@cianclarke

@erictune Sure - when attempting to integrate with k8 APIs using https://github.com/swagger-api/swagger-js, I discovered that due to the duplicated…

@cianclarke
Swagger API documentation nicknames should include unique for each operation
@cianclarke
@cianclarke
@cianclarke
cianclarke commented on pull request feedhenry/fh-fhc#135
@cianclarke

@nialldonnellyfh No action here, right? Looks like a culmination of reviewed PRs?

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

1,725 additions and 1,327 deletions. - great stuff, with added functionality barely 400 lines extra. The new approach to commands seems to help DRY…

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

Are we breaking the previous forms FHC APIs with this change? Should this definitely be a major bump? I'm also thinking yes, but just wanted to ra…

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

Should fileStream also have an error listner? What happens if the specified filePath doesn't exist, or permissions are lacking?

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

as before, check for err maybe

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

as below, maybe consider checking for err as well as relying on try/catch handler?

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

Maybe check for err here? I know submissionFileContent will cause the try/catch to fail, but a more meaningful error will be populated here than b…

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

Another fs.exists

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

As above note on fs.exists

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

Isn't fs.exists due for deprecation? https://nodejs.org/api/fs.html#fs_fs_exists_path_callback Hasn't yet been marked as such, but not sure if it'd…

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

Nvm - submissionFileContent falls back to "", and JSON.parse fails on JSON.parse('')

cianclarke commented on pull request feedhenry/fh-fhc#129
@cianclarke

potential for submissionJSON to be undefined?

@cianclarke

Thanks @huangqg for the quick merge & publish :+1:

@cianclarke
cianclarke commented on pull request cianclarke/node-gallery#16
@cianclarke

Published + node-gallery@1.1.0

@cianclarke
Corrected package.json so it will work
cianclarke commented on pull request cianclarke/node-gallery#15
@cianclarke

This has been long fixed - should have closed earlier,my bad :-)

@cianclarke
  • @cianclarke 67961ff
    CSS tweaks for enhanced html markup. Ensure gallery css returns corre…
cianclarke commented on pull request cianclarke/node-gallery#17
@cianclarke

Sorry for the delay in merging this! I had to make some CSS tweaks, as the figure elements had an extra margin added by default in browsers.

@cianclarke
@cianclarke
Add semantic tags and classes to view templates for easier CSS styling.
1 commit with 33 additions and 15 deletions