This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Remove ciao-cli #1634
Merged
Remove ciao-cli #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdryan
reviewed
Jan 8, 2018
bat/workload.go
Outdated
| @@ -17,9 +17,9 @@ | |||
| // Package bat contains a number of helper functions that can be used to perform | |||
| // various operations on a ciao cluster such as creating an instance or retrieving | |||
| // a list of all the defined workloads, etc. All of these helper functions are | |||
| // implemented by calling ciao-cli rather than by using ciao's REST APIs. This | |||
| // implemented by calling ciaorather than by using ciao's REST APIs. This | |||
bat/workload.go
Outdated
| // to upload the workload definition. It will clean up all the files it | ||
| // created when it is done. | ||
| func CreatePublicWorkload(ctx context.Context, tenant string, opt WorkloadOptions, config string) (string, error) { | ||
| return createWorkload(ctx, "", opt, config, true) | ||
| } | ||
|
|
||
| // CreateWorkloadFromFile will call ciao-cli workload create -yaml | ||
| // to create a workload from the specified file. ciao-cli will be invoked | ||
| // CreateWorkloadFromFile will call ciao create worjload |
Update test and help text to use new binary. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Replace comments with ciao-cli commands for ciao versions. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
Update the remaining documentation that still mentions ciao-cli. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
The ciao-cli tool has been replace by the ciao tool. Signed-off-by: Rob Bradford <robert.bradford@intel.com>
rbradford
force-pushed
the
remove-ciao-cli
branch
from
fd6d849
to
a4d6d8a
Compare
|
All done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalise the removal of ciao-cli by updating remaining documentation (website already updated) and remove from the source tree.