Skip to content
Commits on Jun 19, 2012
  1. Merge branch 'skyrock'

    committed
    Conflicts:
    	README.md
  2. Merge branch 'github_fixes'

    committed
Commits on Jun 17, 2012
  1. Add Skyrock.com provider

    niQo committed
  2. Add Skyrock.com provider

    niQo committed
Commits on Jun 13, 2012
  1. @dennisreimann
Commits on May 29, 2012
  1. @evanp

    Check the err return from generateAccessToken()

    evanp committed
    We weren't checking the err result from the OAuth provider's
    generateAccessToken(), which would cause reference errors if the
    result was null or undefined.
    
    Now, check it, and return an error if there is one.
Commits on May 28, 2012
  1. Merge pull request #105 from evanp/AuthorizeCheckErr

    committed
    check error results from fetchAuthorizationInformation()
  2. Merge pull request #104 from evanp/ReturnAssociateResult

    committed
    authenticateUser() should pass results of associateTokenToUser() to callback
  3. Merge pull request #101 from evanp/RealmOAuth

    committed
    Change default realm for OAuth to 'oauth'
  4. @evanp

    Also check intermediate error for fetchAuthorizationInformation()

    evanp committed
    We were also skipping over the intermediate error from the provider's
    fetchAuthorizationInformation(), which will cause an (incorrect) error
    about the provider interface.
  5. @evanp

    authorizeUrlMethod() checks err returned from fetchAuthorizationInfor…

    evanp committed
    …mation()
    
    We weren't checking the err response before. This patch adds a quick check and a call to the authorize_provider if there's an error.
  6. @evanp

    authenticateUser() should pass results of associateTokenToUser() to c…

    evanp committed
    …allback
    
    The authenticateUser() method of the OAuthServices class was returning
    the results of provider.authenticateUser() instead of provider.associateTokenToUser().
    
    This gives incorrect results if associateTokenToUser() doesn't return
    the identical object (the in-memory provider does, which is probably why this doesn't come up).
    
    This patch changes the function so that if associateTokenToUser()
    returns a non-identical object (say, if you use a database) you get
    the most up-to-date object back.
Commits on May 25, 2012
  1. @evanp

    Change default realm for OAuth to 'oauth'

    evanp committed
    The documentation comment says the default realm is 'oauth', but the
    default code was setting it to the string 'realm'. To harmonize the
    two, I used the more descriptive 'oauth'.
Commits on May 23, 2012
  1. @evanp
  2. @evanp
Commits on May 16, 2012
  1. @evanp

    Pass correct parameter to previousRequestToken()

    evanp committed
    We used to pass oauth_consumer_key to previousRequestToken(); this patch
    passes the correct token parameter instead.
  2. Fixing Issue #96 - Object #<Object> has no method 'fail' (Twitter)

    committed
    There was an invalid reference to 'this.fail', 'fail'
    is not defined in that particular scope at the point where
    the twitter callback fails, it was a typo, should've been
    self. Now is.
  3. Minor fixes to Evan's work on Issue #97 ( tokenByTokenAndConsumer )

    committed
    'Cached' which method ( tokenByTokenAndConsumer or tokenByConsumer)
    the provider is providing, and stopped testing for the token methods
    for *each* required method in the loop (typo.)
  4. Merge pull request #92 from evanp/only_sign_post_form_types

    committed
    Only consider body attributes as parameters if Content-Type is applicati...
  5. Merge pull request #90 from evanp/Issue89

    committed
    Check err param in callback from OAuthDataProvider's applicationByConsum...
  6. @evanp

    Add tokenByTokenAndConsumer() to allow multiple request tokens per co…

    evanp committed
    …nsumer
    
    Per Issue #97, the tokenByConsumer() method assumes only a single
    request token per client application.
    
    This would prevent two users from authorizing the same app at the same
    time -- unfortunate!
    
    This patch creates a new OAuthDataProvider method,
    tokenByTokenAndConsumer(), which retrieves the full value based on
    both the token and the consumer_key.
    
    Providers that already implement tokenByConsumer() should continue
    working, but newer apps can ignore it and implement the newer method.
Commits on Mar 23, 2012
  1. @xentac

    Fix a refactoring typo that made verifyToken disappear

    xentac committed
    I also changed the indent of verifyToken so it hopefully won't happen
    again.
Commits on Mar 19, 2012
  1. @evanp

    Only consider body attributes as parameters if Content-Type is applic…

    evanp committed
    …ation/x-www-form-urlencoded
    
    Fixes Issue #91.
    
    We only consider body attributes as parameters if they're actually
    parameters per http://tools.ietf.org/html/rfc5849#section-3.4.1.3.
  2. @evanp

    Check err param in callback from OAuthDataProvider's applicationByCon…

    evanp committed
    …sumerKey()
    
    Fix for issue #89.
Commits on Mar 8, 2012
  1. Merge remote-tracking branch 'origin/RB-0.4'

    committed
    Conflicts:
    	README.md
    	examples/app.js
    	lib/auth.strategies/google2.js
    	package.json
  2. Updating Google's OAuth2 strategy to request the user profile (and op…

    committed
    …tionally the user's email address)
Commits on Feb 29, 2012
  1. Merge commit '1e8deb7'

    committed
  2. Merge pull request #38 from tonymilne/master

    committed
    Added support for POST params in oauth parseParameters
  3. Fix openid

    committed
Something went wrong with that request. Please try again.