Permalink
Commits on Jun 19, 2012
  1. Merge remote-tracking branch 'mrblur/master' into nk.pl

    Conflicts:
    	README.md
    	examples/example_keys_file.js
    committed Jun 19, 2012
  2. Merge branch 'skyrock'

    Conflicts:
    	README.md
    committed Jun 19, 2012
  3. Merge branch 'github_fixes'

    committed Jun 19, 2012
  4. Minor tweaks to README

    committed Jun 19, 2012
  5. Merge pull request #106 from evanp/CheckGenerateAccessTokenErr

    Check the err return from generateAccessToken()
    committed Jun 19, 2012
Commits on Jun 17, 2012
  1. Add Skyrock.com provider

    niQo committed Jun 17, 2012
  2. Add Skyrock.com provider

    niQo committed Jun 17, 2012
Commits on Jun 13, 2012
  1. @dennisreimann
Commits on May 29, 2012
  1. @evanp

    Check the err return from generateAccessToken()

    We weren't checking the err result from the OAuth provider's
    generateAccessToken(), which would cause reference errors if the
    result was null or undefined.
    
    Now, check it, and return an error if there is one.
    evanp committed May 29, 2012
Commits on May 28, 2012
  1. Merge pull request #105 from evanp/AuthorizeCheckErr

    check error results from fetchAuthorizationInformation()
    committed May 28, 2012
  2. Merge pull request #104 from evanp/ReturnAssociateResult

    authenticateUser() should pass results of associateTokenToUser() to callback
    committed May 28, 2012
  3. Merge pull request #101 from evanp/RealmOAuth

    Change default realm for OAuth to 'oauth'
    committed May 28, 2012
  4. Merge pull request #100 from evanp/ValidateNotReplayClient

    Add validateNotReplayClient() method for OAuthDataProvider
    committed May 28, 2012
  5. @evanp

    Also check intermediate error for fetchAuthorizationInformation()

    We were also skipping over the intermediate error from the provider's
    fetchAuthorizationInformation(), which will cause an (incorrect) error
    about the provider interface.
    evanp committed May 28, 2012
  6. @evanp

    authorizeUrlMethod() checks err returned from fetchAuthorizationInfor…

    …mation()
    
    We weren't checking the err response before. This patch adds a quick check and a call to the authorize_provider if there's an error.
    evanp committed May 28, 2012
  7. @evanp

    authenticateUser() should pass results of associateTokenToUser() to c…

    …allback
    
    The authenticateUser() method of the OAuthServices class was returning
    the results of provider.authenticateUser() instead of provider.associateTokenToUser().
    
    This gives incorrect results if associateTokenToUser() doesn't return
    the identical object (the in-memory provider does, which is probably why this doesn't come up).
    
    This patch changes the function so that if associateTokenToUser()
    returns a non-identical object (say, if you use a database) you get
    the most up-to-date object back.
    evanp committed May 28, 2012
Commits on May 25, 2012
  1. @evanp

    Change default realm for OAuth to 'oauth'

    The documentation comment says the default realm is 'oauth', but the
    default code was setting it to the string 'realm'. To harmonize the
    two, I used the more descriptive 'oauth'.
    evanp committed May 25, 2012
Commits on May 23, 2012
  1. @evanp
  2. @evanp
Commits on May 16, 2012
  1. Merge pull request #99 from evanp/previousRequestTokenArg

    Pass correct parameter to previousRequestToken()
    committed May 16, 2012
  2. Bumping versions to 0.5.2

    committed May 16, 2012
  3. @evanp

    Pass correct parameter to previousRequestToken()

    We used to pass oauth_consumer_key to previousRequestToken(); this patch
    passes the correct token parameter instead.
    evanp committed May 16, 2012
  4. Fixing Issue #96 - Object #<Object> has no method 'fail' (Twitter)

    There was an invalid reference to 'this.fail', 'fail'
    is not defined in that particular scope at the point where
    the twitter callback fails, it was a typo, should've been
    self. Now is.
    committed May 16, 2012
  5. Minor fixes to Evan's work on Issue #97 ( tokenByTokenAndConsumer )

    'Cached' which method ( tokenByTokenAndConsumer or tokenByConsumer)
    the provider is providing, and stopped testing for the token methods
    for *each* required method in the loop (typo.)
    committed May 16, 2012
  6. Merge pull request #92 from evanp/only_sign_post_form_types

    Only consider body attributes as parameters if Content-Type is applicati...
    committed May 16, 2012
  7. Merge pull request #90 from evanp/Issue89

    Check err param in callback from OAuthDataProvider's applicationByConsum...
    committed May 16, 2012
  8. Merge pull request #93 from xentac/master

    verifyToken was removed during a refactor
    committed May 16, 2012
  9. @evanp

    Add tokenByTokenAndConsumer() to allow multiple request tokens per co…

    …nsumer
    
    Per Issue #97, the tokenByConsumer() method assumes only a single
    request token per client application.
    
    This would prevent two users from authorizing the same app at the same
    time -- unfortunate!
    
    This patch creates a new OAuthDataProvider method,
    tokenByTokenAndConsumer(), which retrieves the full value based on
    both the token and the consumer_key.
    
    Providers that already implement tokenByConsumer() should continue
    working, but newer apps can ignore it and implement the newer method.
    evanp committed May 16, 2012
Commits on Mar 23, 2012
  1. @xentac

    Fix a refactoring typo that made verifyToken disappear

    I also changed the indent of verifyToken so it hopefully won't happen
    again.
    xentac committed Mar 23, 2012
Commits on Mar 19, 2012
  1. @evanp

    Only consider body attributes as parameters if Content-Type is applic…

    …ation/x-www-form-urlencoded
    
    Fixes Issue #91.
    
    We only consider body attributes as parameters if they're actually
    parameters per http://tools.ietf.org/html/rfc5849#section-3.4.1.3.
    evanp committed Mar 19, 2012
  2. @evanp

    Check err param in callback from OAuthDataProvider's applicationByCon…

    …sumerKey()
    
    Fix for issue #89.
    evanp committed Mar 19, 2012
Commits on Mar 9, 2012
  1. Fix whitespace :)

    Kamil Kamiński committed Mar 9, 2012