Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

check error results from fetchAuthorizationInformation() #105

Merged
merged 2 commits into from May 28, 2012

Conversation

Projects
None yet
2 participants
Contributor

evanp commented May 28, 2012

The code wasn't checking error results from fetchAuthorizationInformation(). It does now, and delegates to the authorization_provider to display them.

evanp added some commits May 28, 2012

authorizeUrlMethod() checks err returned from fetchAuthorizationInfor…
…mation()

We weren't checking the err response before. This patch adds a quick check and a call to the authorize_provider if there's an error.
Also check intermediate error for fetchAuthorizationInformation()
We were also skipping over the intermediate error from the provider's
fetchAuthorizationInformation(), which will cause an (incorrect) error
about the provider interface.

ciaranj added a commit that referenced this pull request May 28, 2012

Merge pull request #105 from evanp/AuthorizeCheckErr
check error results from fetchAuthorizationInformation()

@ciaranj ciaranj merged commit ec9dcad into ciaranj:master May 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment