Skip to content
Browse files

Merge pull request #76 from pnegri/live_protocol

[ #Issue 75 ] Fixing Live Protocol 302 Resources
  • Loading branch information...
2 parents fd4b2bb + 6404f6e commit 200713494413bcec92e5d7dc82c9511b819934c9 @ciaranj committed Oct 27, 2011
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/oauth2.js
View
2 lib/oauth2.js
@@ -64,7 +64,7 @@ exports.OAuth2.prototype._request= function(method, url, headers, post_body, acc
function passBackControl( response, result ) {
if(!callbackCalled) {
callbackCalled=true;
- if( response.statusCode != 200 ) {
+ if( response.statusCode != 200 && (response.statusCode != 301) && (response.statusCode != 302) ) {
callback({ statusCode: response.statusCode, data: result });
} else {
callback(null, result, response);

7 comments on commit 2007134

@pnegri
Collaborator
pnegri commented on 2007134 Mar 2, 2012

Hey ciaranj. This pull request got lost in a next update. Live isnt working anymore.

Can you check and remerge it?

@ciaranj
Owner
ciaranj commented on 2007134 Mar 2, 2012

Weird... wonder how that got knocked out... will investigate.

@ciaranj
Owner
ciaranj commented on 2007134 Mar 2, 2012

Now I'm confused. Do you mean the commit isn't in npm ? .. in which case it looks like I've never released a version with that fix actually in it!

@pnegri
Collaborator
pnegri commented on 2007134 Mar 2, 2012

Ahh.
Was working in development, and after first production deployment didnt.
Can you merge this ciaranj?
Windows Live Apps (Photos / Thumbs) only work with that fix in.

@ciaranj
Owner
ciaranj commented on 2007134 Mar 2, 2012

let me check

@pnegri
Collaborator
pnegri commented on 2007134 Mar 2, 2012

To get the user profile in Live, use "http://apis.live.net/v5.0/me/picture". The problem is, the URL of image comes in a 302 response.

@ciaranj
Owner
ciaranj commented on 2007134 Mar 2, 2012

Yeah I understand, don't worry, I was just checking that the master branch was 'safe' to publish a new version. It was and I've now published to npm 0.9.6 hopefully this will sort you out!

Please sign in to comment.
Something went wrong with that request. Please try again.