Add support for setting Content-Type on GETs #182

Open
dancrumb opened this Issue Feb 14, 2014 · 1 comment

Projects

None yet

2 participants

@dancrumb

The current implementation forces the Content-Type header to be "application/x-www-form-urlencoded", when using consumer.get.

Some services do not support this Content-Type header on a GET. Whether they are right or wrong to do this, it makes it impossible to use .get for these endpoints.

I propose support for a default Content-Type header, settable via the customHeaders parameters of the constructor and overridable via the post_content_type parameter of _performSecureRequest

@dancrumb dancrumb pushed a commit to dancrumb/node-oauth that referenced this issue Feb 18, 2014
Dan Rumney #182: Added support for setting Content-Type for GETs 193b0c6
@hairyhenderson

This is affecting me too. This should certainly be overridable. It should also be possible to leave Content-Type unset for methods that don't contain bodies. Content-Type is meaningless on a GET, HEAD, or DELETE request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment