OAuth2.js getOAuthAccessToken not returning all data to the callback. #20

ramv opened this Issue Dec 20, 2010 · 2 comments


None yet
3 participants

ramv commented Dec 20, 2010

Gowalla returns more data than just access_token and refresh_token.

Line 106 in oauth2.js

callback(null, access_token, refresh_token);

should be

callback(null, access_token, refresh_token, results);

gidzone commented Aug 31, 2011

This would be a great modification. Salesforce returns more data as well.

gidzone added a commit to gidzone/node-oauth that referenced this issue Sep 1, 2011

issue #20: returned results to the callback along with access_token a…
…nd refresh_token

Other implementations return more than just access_token and the
refresh_token.  For example, salesforce returns the instance url.

ciaranj commented Apr 24, 2012

This is now merged (although sorry @gidzone not the above commit, that pull request was also 'tainted' with a more contentious commit around 302 handling, so I had to pull in someone else' implementation of the same fix ;) )

@ciaranj ciaranj closed this Apr 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment