Fix requests containing !'()* in POST data #114

Merged
merged 1 commit into from Nov 25, 2012

Conversation

Projects
None yet
4 participants
Contributor

rolandboon commented Sep 28, 2012

This pull request fixes the mismatch between the output of querystring.stringify() and this._encodeData(), as discussed in #113.

Credits for NicolasPelletier for identifying the cause of this issue: #113 (comment)

Update lib/oauth.js
Fix the mismatch between the output of querystring.stringify() and this._encodeData(). 

LGTM

Looks good to me too :)

Thanks for making this pull request rolandboon.

Owner

ciaranj commented Nov 20, 2012

Sorry for the delay on this, any chance of running up a quick test case and I'll get it merged ASAP.

Not at all. That is the beauty of open source. We could use this fix directly in the code on our server until you made the official version.

Thanks for a great and very useful module.

Cheers !

ciaranj added a commit that referenced this pull request Nov 25, 2012

Merge pull request #114 from rolandboon/master
Fix requests containing !'()* in POST data

@ciaranj ciaranj merged commit 45a983e into ciaranj:master Nov 25, 2012

Owner

ciaranj commented Nov 25, 2012

Merged, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment