Add RSA-SHA1 support #121

Merged
merged 1 commit into from Jan 4, 2014

Conversation

Projects
None yet
4 participants

This builds on a fork from https://github.com/wraithgar/node-oauth. All I did was to basically add a test that ensures creating a signature with RSA-SHA1 works and that this signature can then be verified with a matching public key.

(See comments in #43).

I also verified that this works against a working OAuth service provider using RSA-SHA1 (Atlassian JIRA).

Andreas Knecht Added RSA-SHA1 signature method based on the fork from https://github…
….com/wraithgar/node-oauth.  Added test that uses the RSA-SHA1 method and verifies the signature using a public key.
635ee2c

knechtandreas referenced this pull request Dec 20, 2012

Closed

Adds RSA-SHA1 Support #43

Thanks for getting this put together.

Hello all. Any reason why this hasn't been merged in?

@ciaranj ciaranj added a commit that referenced this pull request Jan 4, 2014

@ciaranj ciaranj Merge pull request #121 from knechtandreas/master
Add RSA-SHA1 support
d228aeb

@ciaranj ciaranj merged commit d228aeb into ciaranj:master Jan 4, 2014

Owner

ciaranj commented Jan 4, 2014

Merged. Thank you.

PaulMougel referenced this pull request in hapijs/bell Jun 2, 2016

Closed

OAuth v1: How to handle RSA-SHA1 signing? #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment