GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Here is a new branch for merge, tells me if it fits better. It rollbacks all my doc/package name updates.
See below for changes in code, it is much cleaner.
You can test in your environment with mocha tests/oauth-tunnel.js
By default you will receive this message by running test
"message":"Bad Authentication data","code":215
but by putting your real twitter keys, you will see God !!
start tunnel integration
tunnel proxy integration
tests mocha with homemade proxy
This reverts commit 364f9f2.
Revert "Revert "doc""
This reverts commit c2f7507.
Revert "Update package.json"
This reverts commit 8073d11.
revert changed named
This rolls back to commit 24597c4.
real test behind fake proxy
mocha test suite launcher
ok, vows and mocha test case compatibility
do you think it is correct or should I create another branch ?
Look in "Files changes", only change I see now is tunnel dependency add. But maybe I am still wrong.
@darul75 yah sorry, I see that now. Just a lot going on as far as commits.
But you are right, I had to revert many things because I was thinking to make my own repo few month ago as I did not get any feedback from lib author ;) And I started renamed it etc...but all is revert now normally. I have made many tests and not seen any big mistake.
Any update on this PR ?
Errr, I've not had chance to look at it :/ But a brief look at it suggests I won't pull it in , in the current state, far too many commits and changes upon changes :/ Needs some re-work before consideration I'm afraid :(
if you want I can try redo the PR as it was not very cleaned when I pushed it.
It seems popular so it may be worth the effort , but I would want the tunnel dependency to be 'optional' :)
yes I understand, what are your propositions to achieve it then
Hmm, I have none :/ Certainly putting it in the package.json as an optional dep, and making the code execute conditionally if the module is present or not would be one approach ?
Per optional dependencies - https://www.npmjs.org/doc/files/package.json.html#optionaldependencies
it looks like a nice solution, I will refactor PR as soon as my girlfriend let me free time ;)
fix #184 proxy tunnel integration