2 minor code changes #65

wants to merge 3 commits into


None yet

2 participants

gidzone commented Sep 1, 2011

fixed issue #20 to return results to support more than just access_token and refresh token
Made a change to handle 302 responses like 200

gidzone added some commits Sep 1, 2011
@gidzone gidzone issue #20: returned results to the callback along with access_token a…
…nd refresh_token

Other implementations return more than just access_token and the
refresh_token.  For example, salesforce returns the instance url.
@gidzone gidzone Handle the 302 response like the 200.
Salesforce returns at 302 with its oath flow.  Handle the 302 status
code like the 200.
ciaranj commented on dc0b92c Sep 4, 2011

looks good, I guess there should be a delete results["access_token"] in there as well now we're actually passing that literal back to the consumer (tbh I'm not sure why the delete results["refresh_token"] is in there, but its always good to be consistent!

If you wouldn't mind adjusting that i'll gratefully/happily pull in both your submitted commits ? :)


@gidzone gidzone added delete results["access_token"];
added delete results["access_token"];

Added delete results["access_token"]; to stay consistent with delete
gidzone commented Sep 5, 2011

Should be good to go.



Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment