Fix IE check on FastBoot #543

Merged
merged 1 commit into from Jun 14, 2016

Conversation

Projects
None yet
2 participants
@josemarluedke
Contributor

josemarluedke commented Jun 10, 2016

This fixes #529.

+const isIE = () => {
+ if (isFastBoot()) { return false; }
+
+ const ua = self.window ? self.window.navigator.userAgent : '';

This comment has been minimized.

@cibernox

cibernox Jun 10, 2016

Owner

Maybe it is easier to just do

const ua = self.window && self.window.navigator ? self.window.navigator.userAgent : '';
@cibernox

cibernox Jun 10, 2016

Owner

Maybe it is easier to just do

const ua = self.window && self.window.navigator ? self.window.navigator.userAgent : '';

This comment has been minimized.

@josemarluedke

josemarluedke Jun 14, 2016

Contributor

👍 Changed!

@josemarluedke

josemarluedke Jun 14, 2016

Contributor

👍 Changed!

@josemarluedke josemarluedke changed the title from Only check if is IE if not running in FastBoot to Fix IE check on FastBoot Jun 14, 2016

@josemarluedke

This comment has been minimized.

Show comment
Hide comment
@josemarluedke

josemarluedke Jun 14, 2016

Contributor

@cibernox changes applied. Ready for merge.

Contributor

josemarluedke commented Jun 14, 2016

@cibernox changes applied. Ready for merge.

@cibernox

This comment has been minimized.

Show comment
Hide comment
@cibernox

cibernox Jun 14, 2016

Owner

The master branch is broken for other reasons. I'll cherry pick this commit onto the 0.10 branch tonight

Owner

cibernox commented Jun 14, 2016

The master branch is broken for other reasons. I'll cherry pick this commit onto the 0.10 branch tonight

@cibernox cibernox merged commit abedd21 into cibernox:master Jun 14, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@cibernox

This comment has been minimized.

Show comment
Hide comment
@cibernox

cibernox Jun 14, 2016

Owner

I've cherry-picked this change into 0.10.11.

Owner

cibernox commented Jun 14, 2016

I've cherry-picked this change into 0.10.11.

@josemarluedke josemarluedke deleted the josemarluedke:fix-error-fastboot branch Jun 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment