Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE check on FastBoot #543

Merged
merged 1 commit into from Jun 14, 2016
Merged

Conversation

josemarluedke
Copy link
Contributor

@josemarluedke josemarluedke commented Jun 10, 2016

This fixes #529.

@josemarluedke josemarluedke force-pushed the fix-error-fastboot branch 2 times, most recently from a0f13ae to d36f3c7 Compare Jun 10, 2016
const isIE = () => {
if (isFastBoot()) { return false; }

const ua = self.window ? self.window.navigator.userAgent : '';
Copy link
Owner

@cibernox cibernox Jun 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is easier to just do

const ua = self.window && self.window.navigator ? self.window.navigator.userAgent : '';

Copy link
Contributor Author

@josemarluedke josemarluedke Jun 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Changed!

@josemarluedke josemarluedke changed the title Only check if is IE if not running in FastBoot Fix IE check on FastBoot Jun 14, 2016
@josemarluedke
Copy link
Contributor Author

@josemarluedke josemarluedke commented Jun 14, 2016

@cibernox changes applied. Ready for merge.

@cibernox
Copy link
Owner

@cibernox cibernox commented Jun 14, 2016

The master branch is broken for other reasons. I'll cherry pick this commit onto the 0.10 branch tonight

@cibernox cibernox merged commit abedd21 into cibernox:master Jun 14, 2016
1 check failed
@cibernox
Copy link
Owner

@cibernox cibernox commented Jun 14, 2016

I've cherry-picked this change into 0.10.11.

@josemarluedke josemarluedke deleted the fix-error-fastboot branch Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants