Totally restfull controllers

cibernox · May 6, 2012 · 51dd258 · 51dd258
1 parent cd8eeb0
commit 51dd258
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 103 deletions.
diff --git a/app/assets/javascripts/common.js.coffee b/app/assets/javascripts/common.js.coffee
@@ -4,13 +4,11 @@ jQuery ->
     $button = $(this)
     $form = $button.closest('form')
     if $button.hasClass 'edit'
-      $form.find('input').each (index, input) ->
+      $(input).removeClass('disabled').prop('disabled', false) for input in $form.find('input')
-        $(input).removeClass('disabled').prop('disabled', false)
-        # TODO: error, se está eliminando el texto del boton también
       $button.removeClass('edit').addClass('btn-danger').html('<i class="icon-remove"></i> Cancelar')
     else
-      $form.find('input').each (index, input) ->
+      for input in $form.find('input')
-        $(input).addClass('disabled').prop('disabled', true)
+        $(input).addClass('disabled').prop 'disabled', true
         $(input).val($(input).data('original')) if input.type != 'submit'
       $button.addClass('edit').removeClass('btn-danger').html('<i class="icon-edit"></i> Editar')
       $form.hideValidationErrors()

diff --git a/app/controllers/issues_controller.rb b/app/controllers/issues_controller.rb
@@ -1,72 +1,42 @@
 # -*- encoding : utf-8 -*-
 class IssuesController < ApplicationController
-
+  respond_to :html, :json
-  def index
+
-    @issues = Issue.all
+  #
-
+  # Decent exposure
-    respond_to do |format|
+  #
-      format.html
+  expose(:project) { Project.find(params[:project_id]) }
-      format.json { render json: @issues }
+  expose(:issues) { project.issues }
-    end
+  expose(:issue)
+
+ def index
+    respond_with issues
   end
 
   def show
-    @issue = Issue.find(params[:id])
+    respond_with issue
-
-    respond_to do |format|
-      format.html
-      format.json { render json: @issue }
-    end
   end
 
   def new
-    @issue = Issue.new
+    respond_with issue
-
-    respond_to do |format|
-      format.html
-      format.json { render json: @issue }
-    end
   end
 
   def edit
-    @issue = Issue.find(params[:id])
+    respond_with issue
   end
 
   def create
-    @issue = Issue.new(params[:issue])
+    issue.save
-
+    respond_with issue
-    respond_to do |format|
-      if @issue.save
-        format.html { redirect_to @issue, notice: 'Issue was successfully created.' }
-        format.json { render json: @issue, status: :created, location: @issue }
-      else
-        format.html { render action: "new" }
-        format.json { render json: @issue.errors, status: :unprocessable_entity }
-      end
-    end
   end
 
   def update
-    @issue = Issue.find(params[:id])
+    issue.save
-
+    respond_with issue
-    respond_to do |format|
-      if @issue.update_attributes(params[:issue])
-        format.html { redirect_to @issue, notice: 'Issue was successfully updated.' }
-        format.json { head :no_content }
-      else
-        format.html { render action: "edit" }
-        format.json { render json: @issue.errors, status: :unprocessable_entity }
-      end
-    end
   end
 
   def destroy
-    @issue = Issue.find(params[:id])
+    issue.destroy
-    @issue.destroy
+    respond_with issue
-
-    respond_to do |format|
-      format.html { redirect_to issues_url }
-      format.json { head :no_content }
-    end
   end
 end
diff --git a/app/controllers/projects_controller.rb b/app/controllers/projects_controller.rb
@@ -1,72 +1,41 @@
 # -*- encoding : utf-8 -*-
 class ProjectsController < ApplicationController
-
+  respond_to :html, :json
+
   #
   # Decent exposure
   #
   expose(:projects) { Project.all }
   expose(:project)
 
   def index
-    respond_to do |format|
+    respond_with projects
-      format.html
-      format.json { render json: projects }
-    end
   end
 
   def show
-    respond_to do |format|
+    respond_with project
-      format.html
-      format.json { render json: project }
-    end
   end
 
   def new
-    respond_to do |format|
+    respond_with project
-      format.html
-      format.json { render json: project }
-    end
   end
 
   def edit
-    @project = Project.find(params[:id])
+    respond_with project
   end
 
   def create
-    @project = Project.new(params[:project])
+    project.save
-
+    respond_with project
-    respond_to do |format|
-      if @project.save
-        format.html { redirect_to @project, notice: 'Project was successfully created.' }
-        format.json { render json: @project, status: :created, location: @project }
-      else
-        format.html { render action: "new" }
-        format.json { render json: @project.errors, status: :unprocessable_entity }
-      end
-    end
   end
 
   def update
-    @project = Project.find(params[:id])
+    project.save
-
+    respond_with project
-    respond_to do |format|
-      if @project.update_attributes(params[:project])
-        format.html { redirect_to @project, notice: 'Project was successfully updated.' }
-        format.json { head :no_content }
-      else
-        format.html { render action: "edit" }
-        format.json { render json: @project.errors, status: :unprocessable_entity }
-      end
-    end
   end
 
   def destroy
-    @project = Project.find(params[:id])
+    project.destroy
-    @project.destroy
+    respond_with project
-
-    respond_to do |format|
-      format.html { redirect_to projects_url }
-      format.json { head :no_content }
-    end
   end
 end
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
@@ -1,5 +1,6 @@
 class UsersController < ApplicationController
   respond_to :html, :json
+
   #
   # Filters
   #
@@ -21,15 +22,12 @@ def edit
   end
 
   def create
-    if user.save
+    auto_login user if user.save
-      auto_login user
-      flash[:notice] = "User was created successfully."
-    end
     respond_with user, location: root_url
   end
 
   def update
-    flash[:notice] = "User was created updated." if user.save
+    user.save
     respond_with user
   end