Miguel Camba cibernox

cibernox commented on issue emberjs/rfcs#78
@cibernox

An addition to this RFC i'd like to see (or perhaps a different one, although related) is to add a implicit name to the outlet (similarly to the pr…

@cibernox

Regardless of the technical details of how have access to the currentRouteName the fact that makes me resilent of implementhing this is the one I e…

cibernox deleted branch assert_presence_of_getter_in_cps at cibernox/ember.js
@cibernox
@cibernox
Bump yuidocjs version to ^0.9.0
1 commit with 2 additions and 2 deletions
cibernox commented on pull request cibernox/ember-cli-yuidoc#26
@cibernox

Thanks!

@cibernox
  • @cibernox f50e6c4
    [BUGFIX beta] Add assertions to CPs that catch most common mistakes
@cibernox
  • @cibernox 85d744f
    [BUGFIX beta] Assert presence of getter function
@cibernox
@cibernox
@cibernox
  • @cibernox 3ab6eb5
    [BUGFIX beta] Assert presence of getter function
cibernox commented on pull request emberjs/ember.js#12156
@cibernox

Ok, added assertions for: Computed properties need to receive either a function or a configuration object as last argument. It guards against: co…

@cibernox
  • @cibernox 8371c60
    [BUGFIX beta] Assert presence of getter function
@cibernox
  • @cibernox 5b0ab81
    [BUGFIX beta] Assert presence of getter function
cibernox commented on pull request emberjs/ember.js#12156
@cibernox

That cache we are thinking we might remove? :trollface: Seriously speaking, I can change the assertion to check that you either pass a getter or a setter, b…

cibernox commented on pull request emberjs/ember.js#12156
@cibernox

@stefanpenner You can define only a setter, but that's because the getter will have a default (just getting the property). In other words, definePr…

cibernox commented on pull request emberjs/ember.js#12156
@cibernox

I wouldn't consider it valid. Does ES5 to have setters without getter? I think you can have readonly properties, but not writeonly, do you?

cibernox commented on pull request emberjs/ember.js#12156
@cibernox

Bugfix is probably not the best tag, but I couldn't find a better one.

cibernox opened pull request emberjs/ember.js#12156
@cibernox
[BUGFIX beta] CPs check presence of getter function
1 commit with 12 additions and 0 deletions
@cibernox
cibernox closed pull request emberjs/ember.js#10778
@cibernox
[WIP] RFC12: Getter CP readOnly by default
cibernox commented on pull request emberjs/ember.js#10778
@cibernox

Not as it is right now. I'll be happy to revisit this (and other CP-related open questions like the one exposed in RFC 79), but the code in this P…

@cibernox
  • @jagthedrummer c9cb214
    Move the helper into test-support and add test-support to the complie…
  • @jagthedrummer 5554e0a
    Add a test helper that stubs a valid torii session.
  • 29 more commits »
cibernox deleted branch each-in-fails-to-render-inverse-with-empty-object at cibernox/ember.js
@cibernox

Published 0.0.1