Miguel Camba cibernox

@cibernox
Glimmer incompatibility
cibernox commented on issue emberjs/ember.js#11048
@cibernox

Having deprecations complaining in runtime might be better (better debug information), but also worse. If you have deprecations in code you don't u…

cibernox commented on issue emberjs/ember.js#11048
@cibernox

We can add key and this to the deprecation message very easily, but I'm not sure how helpful will it be. I'll check later.

cibernox commented on issue trek/pretender#69
@cibernox

@trek see #73 for the implementation details. The change is fairly minimal and I don't see any posibility of leaking since the next progress event …

cibernox opened pull request trek/pretender#73
@cibernox
Simulate progress events
3 commits with 131 additions and 6 deletions
cibernox commented on pull request cibernox/ember-cpm#120
@cibernox

@truenorth Ember try doesn't support older embers?

@cibernox
Remove usage of prototype extensions
cibernox commented on issue cibernox/ember-cpm#119
@cibernox

Added the addon in cacc14b and all tests are still green. I haven't found any evident place were prototype extensions are being used. Closing this …

@cibernox
  • @cibernox cacc14b
    Disable prototype extensions
cibernox commented on issue cibernox/ember-cpm#119
@cibernox

Understood. Added to the pipeline

cibernox commented on issue cibernox/ember-cpm#119
@cibernox

Can you explain this a bit more? Are prototype extensions considered harmful?

cibernox commented on pull request cibernox/ember-cpm#118
@cibernox

Thanks!

@cibernox
cibernox merged pull request cibernox/ember-cpm#118
@cibernox
Ember-cli 0.2.3
2 commits with 23 additions and 14 deletions
@cibernox

@achambers Yes, those are exactly my symptoms. I haven't deployed on the last 2 weeks though.

cibernox commented on issue trek/pretender#69
@cibernox

I don't think that there is any cons. It's a new feature that should't affect in any form to current users. The options are a) Fire the events only…

cibernox commented on issue ember-cli/ember-cli#3979
@cibernox

I might get some time to fix this, but I have on related question. If you don't add the name of the helper to tests/.jshintrc you'll get a warning …

@cibernox
Test helpers are not autodiscovered
cibernox commented on issue trek/pretender#69
@cibernox

Sorry for the insistence, but I'm just waiting some green light to start implementing something.

@cibernox
  • @rwjblue 9e91371
    Merge pull request #10968 from cibernox/fix_breaking_assertion_on_cps
  • @cibernox 332bf34
    Fix assertion to make sure doesn't affect old CP syntax
  • 2 more commits »
cibernox deleted branch fix_breaking_assertion_on_cps at cibernox/ember.js
cibernox commented on pull request emberjs/ember.js#10966
@cibernox

Before merging this, check #10968. I've changed the assertion check to not affect people using the old CP syntax, only people using the new one. I …

cibernox opened pull request emberjs/ember.js#10968
@cibernox
[BUGFIX beta] Fix assertion to make sure doesn't affect old CP syntax
1 commit with 9 additions and 3 deletions
cibernox deleted branch throw_error_on_readonly_properties_with_setter at cibernox/ember.js
cibernox deleted branch es6-getters-setters-in-cps at cibernox/ember.js
cibernox commented on pull request emberjs/ember.js#10950
@cibernox

Finally sauce is green!

cibernox commented on pull request emberjs/ember.js#10761
@cibernox

I haven't considered that, you're right, it's beaking. However, I think I can fix it by adding to the assertion that the getter and the setter are…