New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Important] ghprb plugin has a bug #223

Closed
podarok opened this Issue Jul 8, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@podarok
Copy link
Contributor

podarok commented Jul 8, 2015

GitHub PR Builder plugin has got a bug jenkinsci/ghprb-plugin#134
Please, use ghprb 1.24.4 from here http://updates.jenkins-ci.org/download/plugins/ghprb/1.24.4/ghprb.hpi untill jenkinsci/ghprb-plugin#134 fixed

@podarok podarok added the bug label Jul 8, 2015

@Sanchiz

This comment has been minimized.

Copy link
Member

Sanchiz commented Jul 16, 2015

Also new version doesn't show:

  • "Comment file" in Job settings
  • "Lines of build log to include in comments" in general settings
  • "Published Jenkins URL" in general settings

When you build CI server from scratch, GitHub PR Builder post empty messages to GitHub when build is failed.

I think we should stick to some old version and update org.jenkinsci.plugins.ghprb.GhprbTrigger.xml. because in most cases this file is outdated.

@Sanchiz

This comment has been minimized.

Copy link
Member

Sanchiz commented Dec 18, 2015

How to solve issue with comments in newer versions(not in all) janinko/ghprb#292 (comment)

@podarok

This comment has been minimized.

Copy link
Contributor Author

podarok commented Dec 18, 2015

@Sanchiz can we update ghprb plugin then?

@Sanchiz

This comment has been minimized.

Copy link
Member

Sanchiz commented Dec 18, 2015

@podarok no, it's still not stable janinko/ghprb#292 (comment)

@podarok

This comment has been minimized.

Copy link
Contributor Author

podarok commented Dec 18, 2015

ah, ok, waiting then

@Sanchiz

This comment has been minimized.

Copy link
Member

Sanchiz commented Dec 18, 2015

How to fix not available "Comment file" and "Append portion of build log" field in Global/Job Configuration.

Add this code into <extensions> section in configuration file:

<org.jenkinsci.plugins.ghprb.extensions.comments.GhprbCommentFile>
  <commentFilePath>${WORKSPACE}/commentinfo.md</commentFilePath>
</org.jenkinsci.plugins.ghprb.extensions.comments.GhprbCommentFile>
<org.jenkinsci.plugins.ghprb.extensions.comments.GhprbBuildLog>
  <logExcerptLines>25</logExcerptLines>
</org.jenkinsci.plugins.ghprb.extensions.comments.GhprbBuildLog>

For Global Configuration use /var/lib/jenkins/org.jenkinsci.plugins.ghprb.GhprbTrigger.xml file and for Job configuration /var/lib/jenkins/jobs/JOB_NAME/config.xml.

Related to janinko/ghprb#379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment