New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate unihan data in cihai #3

Closed
tony opened this Issue May 6, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@tony
Member

tony commented May 6, 2017

In order to get cihai working easily out of the box, data from UNIHAN must be incorporated in some way:

  1. Generating an index for the glyphs via iterating through the Codes by regex: https://github.com/cihai/cihai/blob/0a28ce182c5e34e69dbdab8c0c42bef0bc3b1e0d/tests/test_datasets.py

  2. When packages cihai, download cihai and pick out some default fields (like kDictionary) to include with the main set.

  3. Make all versions of cihai download the full UNIHAN.zip afterwords and include the data

@tony

This comment has been minimized.

Member

tony commented May 6, 2017

it is also considered a standard practice to download external library data automatically once a core application (pleco, hanping dictionary) is downloaded and installed.

@tony tony referenced this issue May 7, 2017

Closed

Simplify usage #4

5 of 6 tasks complete
@tony

This comment has been minimized.

Member

tony commented May 8, 2017

Rather than treat UNIHAN and its variants like an extension, its unicode points, variants, strokes, and similar things will play a front and center role in cihai's operation.

@tony tony closed this May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment